OCPBUGS-75917: ctrcfg: set ShortNameMode disabled when ugprading from 4.20 to 4.21

[haircommander]

in cri-o 1.33, a change cri-o/cri-o#9401 was made to the short name mode for CRI-O. Now, CRI-O is enforcing short names, which means when an image is unqualified (short name) and has an ambiguous pull path (multiple different names returned), cri-o fails to pull the image.

This may break users however, and so we shouldn't upgrade with it.

We should drop-in an ignition file on upgrades from 4.20 to 4.21 to make sure existing clusters don't get this change, but new clusters started in 4.21 do.

This was entirely based on #5516, which has its own inspiration history

- What I did

- How to verify it

- Description for the changelog

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[haircommander]

/retitle OCPBUGS-75917: ctrcfg: set ShortNameMode disabled when ugprading from 4.20 to 4.21

[openshift-ci-robot]

@haircommander: This pull request references Jira Issue OCPBUGS-75917, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.0" instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-75916 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Won't Do) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

in cri-o 1.33, a change cri-o/cri-o#9401 was made to the short name mode for CRI-O. Now, CRI-O is enforcing short names, which means when an image is unqualified (short name) and has an ambiguous pull path (multiple different names returned), cri-o fails to pull the image.

This may break users however, and so we shouldn't upgrade with it.

We should drop-in an ignition file on upgrades from 4.20 to 4.21 to make sure existing clusters don't get this change, but new clusters started in 4.21 do.

This was entirely based on #5516, which has its own inspiration history

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	ce2c5e1	link	true	/test unit
ci/prow/e2e-aws-ovn	ce2c5e1	link	true	/test e2e-aws-ovn
ci/prow/e2e-gcp-op-1of2	ce2c5e1	link	true	/test e2e-gcp-op-1of2
ci/prow/e2e-gcp-op-ocl	ce2c5e1	link	false	/test e2e-gcp-op-ocl
ci/prow/bootstrap-unit	ce2c5e1	link	false	/test bootstrap-unit
ci/prow/e2e-gcp-op-single-node	ce2c5e1	link	true	/test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-2of2	ce2c5e1	link	true	/test e2e-gcp-op-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@haircommander: This pull request references Jira Issue OCPBUGS-75917. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

in cri-o 1.33, a change cri-o/cri-o#9401 was made to the short name mode for CRI-O. Now, CRI-O is enforcing short names, which means when an image is unqualified (short name) and has an ambiguous pull path (multiple different names returned), cri-o fails to pull the image.

This may break users however, and so we shouldn't upgrade with it.

We should drop-in an ignition file on upgrades from 4.20 to 4.21 to make sure existing clusters don't get this change, but new clusters started in 4.21 do.

This was entirely based on #5516, which has its own inspiration history

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[haircommander]

closing in favor of #5628