OCPBUGS-77422: Remove MCD liveness probe#5709
Conversation
|
@pablintino: This pull request references Jira Issue OCPBUGS-77422, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout. This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors. Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
47339d5 to
61838b8
Compare
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
/label backport-risk-assessed
Looks like a clean backport.
|
@pablintino: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@pablintino: This pull request references Jira Issue OCPBUGS-77422, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label approved |
|
@sdodson: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pablintino: Jira Issue Verification Checks: Jira Issue OCPBUGS-77422 Jira Issue OCPBUGS-77422 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Fix included in accepted release 4.17.0-0.nightly-2026-03-05-015007 |
Closes: #OCPBUGS-77422
- What I did
The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.
Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.
- How to verify it
- Description for the changelog
Remove unused MCD liveness probe to avoid mid-update restarts.