Skip to content

OCPBUGS-77422: Remove MCD liveness probe#5709

Merged
sdodson merged 1 commit intoopenshift:release-4.17from
pablintino:ocpbugs-77422
Mar 4, 2026
Merged

OCPBUGS-77422: Remove MCD liveness probe#5709
sdodson merged 1 commit intoopenshift:release-4.17from
pablintino:ocpbugs-77422

Conversation

@pablintino
Copy link
Contributor

Closes: #OCPBUGS-77422

- What I did

The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.

- How to verify it

- Description for the changelog

Remove unused MCD liveness probe to avoid mid-update restarts.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 26, 2026
@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-77422, which is invalid:

  • expected dependent Jira Issue OCPBUGS-77421 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: #OCPBUGS-77422

- What I did

The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.

- How to verify it

- Description for the changelog

Remove unused MCD liveness probe to avoid mid-update restarts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

The current liveness probe implementation triggers a container
restart if long-running operations (like rpm-ostree rebases)
exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to
inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a
restart won't solve most of the failures of a slow or wrong update,
removing the probe is the most simple way of preventing inconsistencies
till a proper probe is implemented.

Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

Looks like a clean backport.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 27, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

@pablintino: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pablintino
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 4, 2026
@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-77422, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-77421 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77421 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 4, 2026
@openshift-ci openshift-ci bot requested a review from sergiordlr March 4, 2026 08:54
@sdodson
Copy link
Member

sdodson commented Mar 4, 2026

/label approved
/verified by CI

@openshift-ci-robot
Copy link
Contributor

@sdodson: This PR has been marked as verified by CI.

Details

In response to this:

/label approved
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 4, 2026
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@sdodson sdodson merged commit d509627 into openshift:release-4.17 Mar 4, 2026
10 of 11 checks passed
@openshift-ci-robot
Copy link
Contributor

@pablintino: Jira Issue Verification Checks: Jira Issue OCPBUGS-77422
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77422 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Closes: #OCPBUGS-77422

- What I did

The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.

- How to verify it

- Description for the changelog

Remove unused MCD liveness probe to avoid mid-update restarts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: isabella-janssen, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.17.0-0.nightly-2026-03-05-015007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.