NO-ISSUE: Update AMI collection script for installer changes#5790
NO-ISSUE: Update AMI collection script for installer changes#5790openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@djoshy: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis pull request refactors the AMI update script to process multiple JSON file paths instead of a single file. The script now iterates over each path independently, fetching commit history and extracting AMIs per file while accumulating results across all sources. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/verified bypass This has no affect on the payload, just updates a helper script that is tested by a periodic /override ci/prow/e2e-aws-ovn |
openshift-ci-robot
added
the
verified
|
@djoshy: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test periodic-ci-openshift-machine-config-operator-update-amis |
|
@djoshy: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@djoshy: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hack/update_amis.py`:
- Around line 219-223: The loop over FILE_PATHS silently treats an empty commits
result (from run_command(..., check=False)) as "no commits" and can hide git
failures; update the logic around FILE_PATHS and the run_command call so that if
run_command returns an empty string for a configured path you treat it as an
error instead of skipping it—either call run_command with check=True or
explicitly detect commits == "" and raise/log+exit with a clear message; adjust
the same pattern in the later block (the code at the other occurrence noted) so
both uses of FILE_PATHS/run_command fail fast on empty output rather than
silently continuing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bd8b7845-d4ef-4f2c-b59e-4681003c10d7
📒 Files selected for processing (1)
hack/update_amis.py
|
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op-ocl, ci/prow/e2e-gcp-op-ocl-part1, ci/prow/e2e-gcp-op-ocl-part2, ci/prow/e2e-gcp-op-part1, ci/prow/e2e-gcp-op-part2, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op-ocl, ci/prow/e2e-gcp-op-ocl-part1, ci/prow/e2e-gcp-op-ocl-part2, ci/prow/e2e-gcp-op-part1, ci/prow/e2e-gcp-op-part2, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op-ocl, ci/prow/e2e-gcp-op-ocl-part1, ci/prow/e2e-gcp-op-ocl-part2, ci/prow/e2e-gcp-op-part1, ci/prow/e2e-gcp-op-part2, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-gcp-op-part2 |
|
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-part2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@djoshy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Update script to account for changes from openshift/installer#10321, which splits the rhcos.json into two files.