[release-4.22] OCPBUGS-85156: Bootloader update attempt should be conditional#6011
Conversation
Only invoke bootupd during a layered OS update when Secure Boot is active (via mokutil) and the installed shim is below 15.8-3.el9_2 (the minimum version with safe signing keys), using rpmvercmp for ordering. Both checks fail open: if mokutil or the rpm query is unavailable the update proceeds rather than being silently skipped.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-84842 has been cloned as Jira Issue OCPBUGS-85156. Will retitle bug to link to clone. WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone. /retitle [release-4.22] OCPBUGS-85156: Bootloader update attempt should be conditional DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85156, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm /label backport-risk-assessed /verified later @sergiordlr This has already been pre merge tested on main(5.0), so will be verified post merge by QE |
|
@djoshy: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
/label backport-risk-assessed
Not mandatory for 4.22.0 but nice to get merged regardless
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, openshift-cherrypick-robot, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
0730621
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-85156: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.22.0-0.nightly-2026-05-07-043024 |
This is an automated cherry-pick of #5907
/assign djoshy