Skip to content

[release-4.22] OCPBUGS-86865: Stabilize ocl 4.22#6115

Open
umohnani8 wants to merge 3 commits into
openshift:release-4.22from
umohnani8:stabilize-ocl-4.22
Open

[release-4.22] OCPBUGS-86865: Stabilize ocl 4.22#6115
umohnani8 wants to merge 3 commits into
openshift:release-4.22from
umohnani8:stabilize-ocl-4.22

Conversation

@umohnani8
Copy link
Copy Markdown
Contributor

- What I did
Backport test fixes to stabilize the e2e-ocl tests and remove the monolithic ocl test suite

- How to verify it
CI runs of the sharded tests should be green

- Description for the changelog
stabilize ocl test suite for release-4.22 branch

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2623b2ee-6286-4ebe-97f0-c18ad7362095

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2026
@umohnani8 umohnani8 changed the title [release-4.22]: Stabilize ocl 4.22 [release-4.22] OCPBUGS-86865: Stabilize ocl 4.22 Jun 2, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@umohnani8: This pull request references Jira Issue OCPBUGS-86865, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-86865 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Backport test fixes to stabilize the e2e-ocl tests and remove the monolithic ocl test suite

- How to verify it
CI runs of the sharded tests should be green

- Description for the changelog
stabilize ocl test suite for release-4.22 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umohnani8
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@umohnani8: This pull request references Jira Issue OCPBUGS-86865, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-85117 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-85117 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

umohnani8 added 3 commits June 3, 2026 10:26
TestMachineOSConfigChangeRestartsBuild flakes because the build controller
(running 3 concurrent workers) races between deleteMachineOSConfig for the
previous test's MOSC and addMachineOSConfig for the new test's MOSC. Since
both MOSCs share the same name, deleteMachineOSConfig's label-based query
matches and deletes MOSBs created by the new MOSC.
Fix both the controller and test assertions.

Signed-off-by: Urvashi <umohnani@redhat.com>
The sharded tests are now required, we can remove the
previous monolithic ocl test suite now.

Signed-off-by: Urvashi <umohnani@redhat.com>
…nlyChange

The e2e-ocl-2of2 test suite has a 120-minute Go test timeout. Prior tests
(each doing full image builds at 10-15 min each plus node rollouts) consume
90-113 minutes depending on CI conditions. TestStaleAnnotationClearedOnLayerOnlyChange
runs last and needs ~30 minutes but sometimes only has ~7 minutes left, causing
a timeout panic.

Bump the timeout from 120m to 150m to provide sufficient headroom.

Signed-off-by: Urvashi <umohnani@redhat.com>
@umohnani8 umohnani8 force-pushed the stabilize-ocl-4.22 branch from d22b587 to faeab0b Compare June 3, 2026 14:26
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

@umohnani8: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl d22b587 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@umohnani8
Copy link
Copy Markdown
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants