Skip to content

OCPBUGS-87014: Remove skopeo-install script#6141

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
umohnani8:remove-install-skopeo
Jun 4, 2026
Merged

OCPBUGS-87014: Remove skopeo-install script#6141
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
umohnani8:remove-install-skopeo

Conversation

@umohnani8
Copy link
Copy Markdown
Contributor

@umohnani8 umohnani8 commented Jun 3, 2026

- What I did
Remove the skopeo-install script used for the OCL
test suite as it has now been added as part of the ci config in openshift/release

- How to verify it
OCL test suite should pass

- Description for the changelog

Summary by CodeRabbit

  • Chores
    • Removed Skopeo build dependency from OpenCL E2E test targets.
    • Simplified test environment configuration by removing unnecessary path extensions.

Remove the skopeo-install script used for the OCL
test suite as it has now been added as part of the ci
config in openshift/release

Signed-off-by: Urvashi <umohnani@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Walkthrough

This PR removes skopeo from the machine-config-operator build system. The install-skopeo Makefile target is deleted, and the OCL E2E test targets no longer depend on it or modify the PATH to include skopeo binaries.

Changes

Skopeo Build Dependency Removal

Layer / File(s) Summary
Remove skopeo target and E2E test integration
Makefile
The install-skopeo target and its associated detection logic are removed. The test-e2e-ocl-1of2 and test-e2e-ocl-2of2 targets no longer depend on install-skopeo and their go test invocations no longer prepend /tmp/skopeo/bin to the PATH.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR removes skopeo scripts and updates Makefile. The codebase uses Go testing framework, not Ginkgo, so this check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only infrastructure files (Makefile, hack/install-skopeo.sh removal). No Ginkgo test code changes present, so test quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR removes skopeo-install script; no new Ginkgo e2e tests added. OCL tests are regular Go tests, not Ginkgo-based, so the check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR removes skopeo infrastructure (Makefile targets and installation script), not adding new Ginkgo e2e tests. Check applies only when new tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR only removes build/test infrastructure (Makefile target, skopeo script); no deployment manifests, operator code, or controllers were modified; no scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR only removes skopeo installer script and Makefile targets; no changes to OTE binary code or stdout-related configurations that would violate the contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. It only removes skopeo infrastructure from Makefile and script files. The IPv6 compatibility check applies only to new tests.
No-Weak-Crypto ✅ Passed PR removes skopeo installer script and updates Makefile; no weak crypto patterns (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB) or insecure implementations introduced.
Container-Privileges ✅ Passed PR only removes skopeo-install script and Makefile target; does not add/modify container manifests with privilege escalation flags.
No-Sensitive-Data-In-Logs ✅ Passed PR removes skopeo-install script and Makefile references without introducing any logging of sensitive data like passwords, tokens, APIs, PII, or internal hostnames.
Title check ✅ Passed The title accurately and concisely describes the main change: removing the skopeo-install script. It directly matches the primary objective of the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@umohnani8 umohnani8 changed the title Remove skopeo-install script OCPBUGS-87014: Remove skopeo-install script Jun 3, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@umohnani8: This pull request references Jira Issue OCPBUGS-87014, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Remove the skopeo-install script used for the OCL
test suite as it has now been added as part of the ci config in openshift/release

- How to verify it
OCL test suite should pass

- Description for the changelog

Summary by CodeRabbit

  • Chores
  • Removed Skopeo build dependency from OpenCL E2E test targets.
  • Simplified test environment configuration by removing unnecessary path extensions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Copy Markdown
Member

/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2

Copy link
Copy Markdown
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

OCL tests passed

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [isabella-janssen,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Copy Markdown
Contributor

djoshy commented Jun 4, 2026

/pipleline-required

@isabella-janssen
Copy link
Copy Markdown
Member

/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-gcp-op-single-node
/test e2e-hypershift

/verified by CI
OCL tests passed, no further verification should be necessary.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@isabella-janssen: This PR has been marked as verified by CI.

Details

In response to this:

/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-gcp-op-single-node
/test e2e-hypershift

/verified by CI
OCL tests passed, no further verification should be necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

@umohnani8: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5d88e8d into openshift:main Jun 4, 2026
17 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@umohnani8: Jira Issue Verification Checks: Jira Issue OCPBUGS-87014
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-87014 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

- What I did
Remove the skopeo-install script used for the OCL
test suite as it has now been added as part of the ci config in openshift/release

- How to verify it
OCL test suite should pass

- Description for the changelog

Summary by CodeRabbit

  • Chores
  • Removed Skopeo build dependency from OpenCL E2E test targets.
  • Simplified test environment configuration by removing unnecessary path extensions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants