-
Notifications
You must be signed in to change notification settings - Fork 223
USHIFT-1291: fix gofmt for go 1.20 #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-1291: fix gofmt for go 1.20 #1859
Conversation
Apparently the indentation rules in go 1.20 are different, because `make verify` fails on my host without this change.
|
@dhellmann: This pull request references USHIFT-1291 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @pmtk |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@dhellmann: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apparently the indentation rules in go 1.20 are different, because
make verifyfails on my host without this change.