Skip to content

Conversation

@dhellmann
Copy link
Contributor

Apparently the indentation rules in go 1.20 are different, because
make verify fails on my host without this change.

Apparently the indentation rules in go 1.20 are different, because
`make verify` fails on my host without this change.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023

@dhellmann: This pull request references USHIFT-1291 which is a valid jira issue.

Details

In response to this:

Apparently the indentation rules in go 1.20 are different, because
make verify fails on my host without this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from pacevedom and pmtk May 31, 2023 20:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@dhellmann
Copy link
Contributor Author

/assign @pmtk

@pmtk
Copy link
Member

pmtk commented Jun 1, 2023

/retest

2 similar comments
@pmtk
Copy link
Member

pmtk commented Jun 1, 2023

/retest

@pmtk
Copy link
Member

pmtk commented Jun 1, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

@dhellmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e 3521ca9 link false /test microshift-e2e
ci/prow/e2e-openshift-conformance-reduced-arm 3521ca9 link false /test e2e-openshift-conformance-reduced-arm
ci/prow/microshift-e2e-arm 3521ca9 link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor

ggiguash commented Jun 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 809c1b9 into openshift:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants