USHIFT-1941: Fix osconfig tests failing due to unplanned reboots and service failures

[ggiguash]

Besides adding Wait Until Greenboot Health Check Exited calls following the Reboot MicroShift Host function, the following fixes were implemented:

• Make the systemctl command retry less frequently (once in 15s instead of 10s) not to hit the 10s start limit
• Fixed the Systemctl enable --now call, which was wrong because Systemctl does not expect such usage
• Limited the journalctl output to 32K characters instead of 100 lines. The 32K characters is the max size of RF buffer anyway.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-1941 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

Details

In response to this:

• Implement a generic function for setting a service start limit override.
• Set the limit to 10 in the cleanup-data test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-1941 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

Details

In response to this:

• Implement a generic function for setting and restoring a service start limit override.
• Set the limit to 10 in the cleanup-data test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ggiguash]

/test metal-periodic-test microshift-metal-tests

[ggiguash]

/test metal-periodic-test

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-1941 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Also, make systemctl command retry less frequently not to hit the start limit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-1941 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Besides adding Wait Until Greenboot Health Check Exited calls following the Reboot MicroShift Host function, the following fixes were implemented:

• Make the systemctl command retry less frequently (once in 15s instead of 10s) not to hit the 10s start limit
• Fixed the Systemctl enable --now call, which was wrong because Systemctl does not expect such usage
• Limited the journalctl output to 32K characters instead of 100 lines. The 32K characters is the max size of RF buffer anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ggiguash]

/test metal-periodic-test
/test microshift-metal-tests

[ggiguash]

/test metal-periodic-test

[dhellmann]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 15e3e7b and 2 for PR HEAD 6da5dff in total

[openshift-ci]

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.