Skip to content

USHIFT-1954: Fix the check for resolvConf option in the kubelet configuration file#2667

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:fix_resolve_conf
Nov 30, 2023
Merged

USHIFT-1954: Fix the check for resolvConf option in the kubelet configuration file#2667
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:fix_resolve_conf

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Nov 29, 2023

Looks like the latest systemd-resolved package added quotes on the file name.

# grep "^resolvConf" /var/lib/microshift/resources/kubelet/config/config.yaml
resolvConf: "/run/systemd/resolve/resolv.conf"

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-1954 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Looks like the latest systemd-resolved package added quotes on the file name.

# grep "^resolvConf" /var/lib/microshift/resources/kubelet/config/config.yaml
resolvConf: "/run/systemd/resolve/resolv.conf"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jogeo and pliurh November 29, 2023 07:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 29, 2023

/test microshift-periodic-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@ggiguash: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
Details

In response to this:

/test microshift-periodic-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 29, 2023

/test metal-periodic-test

pmtk
pmtk reviewed Nov 29, 2023
View reviewed changes
@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 29, 2023

/test metal-periodic-test

1 similar comment
@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 29, 2023

/test metal-periodic-test

@pmtk
Copy link
Member

pmtk commented Nov 29, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 29, 2023

/test verify

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

/retest-required

Remaining retests: 0 against base HEAD 153b6f9 and 2 for PR HEAD c9e91db in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

/retest-required

Remaining retests: 0 against base HEAD 3d6866b and 1 for PR HEAD c9e91db in total

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 30, 2023

Need this fix for nightlies to work
/override microshift-metal-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@ggiguash: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • microshift-metal-tests

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/metal-periodic-test
  • ci/prow/microshift-metal-tests
  • ci/prow/test-unit
  • ci/prow/verify
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

Need this fix for nightlies to work
/override microshift-metal-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 30, 2023

/override ci/prow/microshift-metal-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/microshift-metal-tests

Details

In response to this:

/override ci/prow/microshift-metal-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash mentioned this pull request Nov 30, 2023
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a9e78af into openshift:main Nov 30, 2023
@ggiguash ggiguash deleted the fix_resolve_conf branch November 30, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@pliurh pliurh Awaiting requested review from pliurh

1 more reviewer

@pmtk pmtk pmtk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pmtk pmtk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggiguash @openshift-ci-robot @pmtk