Skip to content

NO-ISSUE: Update design.md#2671

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
aldettinger:patch-2
Nov 29, 2023
Merged

NO-ISSUE: Update design.md#2671
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
aldettinger:patch-2

Conversation

@aldettinger
Copy link
Contributor

Small typos fix proposal.

@openshift-ci openshift-ci bot requested review from copejon and jogeo November 29, 2023 16:29
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

Hi @aldettinger. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

/ok-to-test
/retitle NO-ISSUE: Update design.md
/lgtm

Thanks, @aldettinger !

@openshift-ci openshift-ci bot changed the title Update design.md NO-ISSUE: Update design.md Nov 29, 2023
@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 29, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2023
@openshift-ci-robot
Copy link

@aldettinger: This pull request explicitly references no jira issue.

Details

In response to this:

Small typos fix proposal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aldettinger, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@aldettinger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3d6866b into openshift:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants