set DEST_DIR before fetch_tools.sh script#2721
set DEST_DIR before fetch_tools.sh script#2721openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
test/run.sh
Outdated
| "${ROOTDIR}/scripts/fetch_tools.sh" robotframework | ||
| "${ROOTDIR}/scripts/fetch_tools.sh" yq | ||
| DEST_DIR="${RF_VENV}" "${ROOTDIR}/scripts/fetch_tools.sh" robotframework | ||
| DEST_DIR="${RF_VENV}" "${ROOTDIR}/scripts/fetch_tools.sh" yq |
There was a problem hiding this comment.
Why is it necessary to change the default DEST_DIR?
There was a problem hiding this comment.
Because DEST_DIR specifies where to install the tool. robotframework is installed in microshift/_output/robotenv instead of microshift/microshift-rf-tests@tmp/venv. This causes robot framework execution to fail: /home/jenkins/ws/workspace/microshift/microshift-rf-tests/microshift/test/run.sh: line 104: /home/jenkins/ws/workspace/microshift/microshift-rf-tests@tmp/venv/bin/robot: No such file or directory
I found this bug last night Jenkins run: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/microshift/job/microshift-rf-tests/923/console
This change PR reverts the change in the Stress Testing PR
There was a problem hiding this comment.
The reason there's a variable is so if there is environment-specific need it can be handled by the caller of this script. Can we make the installation destination use the default here, and export the variable in the QE script that invokes it?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@agullon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Fix a bug introduced on #2647 PR:
DEST_DIRmust be set right before installing tools to set the proper path.DEST_DIRspecifies where to install the tool. robotframework is installed inmicroshift/_output/robotenvinstead ofmicroshift/microshift-rf-tests@tmp/venv. This causes robot framework execution to fail:/home/jenkins/ws/workspace/microshift/microshift-rf-tests/microshift/test/run.sh: line 104: /home/jenkins/ws/workspace/microshift/microshift-rf-tests@tmp/venv/bin/robot: No such file or directoryI found this bug last night Jenkins run: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/microshift/job/microshift-rf-tests/923/console