Skip to content

USHIFT-2051: always build images not available in the cache#2737

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
dhellmann:USHIFT-2051-smart-image-build
Dec 22, 2023
Merged

USHIFT-2051: always build images not available in the cache#2737
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
dhellmann:USHIFT-2051-smart-image-build

Conversation

@dhellmann
Copy link
Contributor

Also adds a -f flag to force rebuilding locally, and introduces force
logic for source image rebuilds and when building a specific image from
its template.

/assign @ggiguash @pmtk

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 14, 2023

@dhellmann: This pull request references USHIFT-2051 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Also adds a -f flag to force rebuilding locally, and introduces force
logic for source image rebuilds and when building a specific image from
its template.

/assign @ggiguash @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jogeo and pliurh December 14, 2023 14:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@dhellmann dhellmann force-pushed the USHIFT-2051-smart-image-build branch from b3dc50a to b0e9d56 Compare December 14, 2023 16:45
@dhellmann
Copy link
Contributor Author

COPR issue

/retest

@dhellmann dhellmann force-pushed the USHIFT-2051-smart-image-build branch from b0e9d56 to c8b311b Compare December 14, 2023 20:12
@pmtk
Copy link
Member

pmtk commented Dec 21, 2023

/retest

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e97292e and 2 for PR HEAD c8b311b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f42011f and 1 for PR HEAD c8b311b in total

@ggiguash
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73156ed and 0 for PR HEAD c8b311b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cfc98bf into openshift:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants