USHIFT-2071: LVMS docs should include cases where no vgs exist on the system#2740
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@copejon: This pull request references OSDOCS-8983 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Should OSDOCS be used to update customer facing documentation? Maybe this needs USHIFT ticket |
There was a problem hiding this comment.
I feel like following sentence is misplaced - whole paragraph is about scanning volume groups.
MicroShift also checks for the presence of volume groups on the system via
vgs.
I'd move it to beginning of the paragraph and clearly separate 3 cases:
- no vg -> no topolvm
- 1 vg -> topolvm
- many vgs, one of them named microshift -> topolvm
+1 I'll open a ushift ticket for this and link it here. This is just the repo side of the what will also be added to the osdocs. |
copejon
added
help wanted
Signed-off-by: Jon Cope <jcope@redhat.com>
copejon
force-pushed
the
docs-lvms-after-vgs-deleted
branch
from
106abf4 to
47897aa
Compare
openshift-ci
bot
added
approved
copejon
changed the title
|
@copejon: This pull request references USHIFT-2071 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@copejon: This pull request references USHIFT-2071 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test verify |
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
No description provided.