Skip to content

[release-4.20] NO-ISSUE: fix ginkgo name typo #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 9, 2025
Merged

[release-4.20] NO-ISSUE: fix ginkgo name typo #5688

openshift-merge-bot merged 1 commit into from
Nov 9, 2025

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Nov 4, 2025

Manual cherrypick from #5686 PR

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2025

@agullon: This pull request explicitly references no jira issue.

Details

In response to this:

Manual cherrypick from #5686 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eslutsky and jerpeter1 November 4, 2025 07:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

6 similar comments
@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

@pacevedom
Copy link
Contributor

pacevedom commented Nov 5, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/test e2e-aws-tests-cache e2e-aws-tests-cache-arm e2e-aws-tests-cache e2e-aws-tests-cache

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/test e2e-aws-tests-cache e2e-aws-tests-cache-arm e2e-aws-tests-cache e2e-aws-tests-cache

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pacevedom
pacevedom approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed
/label jira/valid-bug
/verified by CI

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 6, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025

/retest-required

Remaining retests: 0 against base HEAD c239b7e and 2 for PR HEAD 617bae9 in total

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025

/retest-required

Remaining retests: 0 against base HEAD edb9c72 and 1 for PR HEAD 617bae9 in total

@agullon
Copy link
Contributor Author

agullon commented Nov 7, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 8, 2025

/test e2e-aws-tests-cache e2e-aws-tests-cache-arm e2e-aws-tests-cache e2e-aws-tests-cache

@agullon
Copy link
Contributor Author

agullon commented Nov 9, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 80129bf into openshift:release-4.20 Nov 9, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eslutsky eslutsky Awaiting requested review from eslutsky

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agullon @openshift-ci-robot @pacevedom