Skip to content

NO-ISSUE: Relax cri-o version dependency for MicroShift RPM#6284

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:relax-crio-version
Feb 26, 2026
Merged

NO-ISSUE: Relax cri-o version dependency for MicroShift RPM#6284
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:relax-crio-version

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Feb 26, 2026

Summary by CodeRabbit

  • Chores
    • Updated CRI-O version requirement to support 1.34.0 and above, expanding compatibility with a broader range of container runtime versions.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2026
@openshift-ci-robot
Copy link

@ggiguash: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 380d437 and e3847b4.

📒 Files selected for processing (1)
  • packaging/rpm/microshift.spec

📝 Walkthrough

Walkthrough

Adjusts the RPM spec file to lower the minimum CRI-O version requirement from 1.35.0 to 1.34.0 while maintaining the upper bound at 1.36.0, and updates the associated comment to reflect the unified version-range targeting for both cri-o and cri-tools.

Changes

Cohort / File(s) Summary
RPM Spec Configuration
packaging/rpm/microshift.spec
Reduced CRI-O minimum version requirement from >= 1.35.0 to >= 1.34.0; upper bound remains < 1.36.0. Updated comment to document version range targeting for both cri-o and cri-tools.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: relaxing the cri-o version dependency in the MicroShift RPM spec from >= 1.35.0 to >= 1.34.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member

pmtk commented Feb 26, 2026

/retest e2e-aws-tests-bootc
/override ci/prow/e2e-aws-tests-bootc-arm ci/prow/e2e-aws-tests-arm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@pmtk: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving
/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-bootc-release
/test e2e-aws-tests-bootc-release-arm
/test e2e-aws-tests-bootc-upstream
/test e2e-aws-tests-bootc-upstream-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test e2e-aws-tests-release
/test e2e-aws-tests-release-arm
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test images
/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-rpm
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify
pull-ci-openshift-microshift-main-verify-deps
Details

In response to this:

/retest e2e-aws-tests-bootc
/override ci/prow/e2e-aws-tests-bootc-arm ci/prow/e2e-aws-tests-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc-arm

Details

In response to this:

/retest e2e-aws-tests-bootc
/override ci/prow/e2e-aws-tests-bootc-arm ci/prow/e2e-aws-tests-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/verified by ci
/override ci/prow/e2e-aws-tests-bootc

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 26, 2026
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci
/override ci/prow/e2e-aws-tests-bootc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc

Details

In response to this:

/verified by ci
/override ci/prow/e2e-aws-tests-bootc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f4fcd85 into openshift:main Feb 26, 2026
12 checks passed
@ggiguash ggiguash deleted the relax-crio-version branch February 26, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants