Skip to content

USHIFT-6682: Temporarily disable gitops tests#6322

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:gitops-scenario-disable
Mar 8, 2026
Merged

USHIFT-6682: Temporarily disable gitops tests#6322
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:gitops-scenario-disable

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented Mar 8, 2026

Summary by CodeRabbit

  • Tests
    • Updated periodic test scenario configuration to change the source reference used when creating VMs.
    • Adjusted test execution to run specific telemetry, cluster-id, and systemd tests directly (removed nested suite path).
    • Added TODO markers around VM creation and test-run steps to indicate follow-up work.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 8, 2026

@ggiguash: This pull request references USHIFT-6682 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c41f9da6-4b63-435b-947e-46d60934685d

📥 Commits

Reviewing files that changed from the base of the PR and between 0d2f64f and 029fe0f.

📒 Files selected for processing (1)
  • test/scenarios-bootc/periodics/el98-src@gitops-telemetry-clusterid-systemd.sh

Walkthrough

Replaced the rhel98-bootc-source-gitops argument with rhel98-bootc-source and removed the suites/gitops/ argument from run_tests; two TODO comment lines were added before the calls. No functional changes to VM removal.

Changes

Cohort / File(s) Summary
Test script update
test/scenarios-bootc/periodics/el98-src@gitops-telemetry-clusterid-systemd.sh
Replaced rhel98-bootc-source-gitops with rhel98-bootc-source; removed suites/gitops/ from run_tests; added two TODO comment lines before the scenario_create_vms and scenario_run_tests invocations. scenario_remove_vms unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'USHIFT-6682: Temporarily disable gitops tests' directly matches the PR's main change: disabling gitops scenario tests by removing the gitops suite argument and adding TODO comments.
Stable And Deterministic Test Names ✅ Passed PR modifies bash shell script, not Ginkgo tests. Static configuration updates do not introduce dynamic test names.
Test Structure And Quality ✅ Passed PR modifies bash scenario orchestration shell scripts, not Ginkgo test code. Custom check applies only to Ginkgo tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from copejon and kasturinarra March 8, 2026 08:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2026
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Mar 8, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2026
@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Mar 8, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the gitops-scenario-disable branch from aafc551 to 0d2f64f Compare March 8, 2026 08:29
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2026
@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Mar 8, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash changed the title USHIFT-6682: Temporarily disable gitops scenario USHIFT-6682: Temporarily disable gitops tests Mar 8, 2026
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Mar 8, 2026

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 8, 2026

@ggiguash: This pull request references USHIFT-6682 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Updated test scenario configuration to modify the test suite execution.
  • Adjusted which test suites run in the periodics workflow, removing one suite from the execution pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2026
@ggiguash ggiguash force-pushed the gitops-scenario-disable branch from 0d2f64f to aa0e221 Compare March 8, 2026 10:54
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2026
@ggiguash ggiguash changed the title USHIFT-6682: Temporarily disable gitops tests USHIFT-6682: Temporarily disable gitops scenario Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 8, 2026

@ggiguash: This pull request references USHIFT-6682 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Updated test scenario configuration to modify the test suite execution.
  • Adjusted which scenarios run in the periodics workflow, removing one scenario from the execution pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Mar 8, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the gitops-scenario-disable branch from aa0e221 to 029fe0f Compare March 8, 2026 11:07
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@ggiguash ggiguash changed the title USHIFT-6682: Temporarily disable gitops scenario USHIFT-6682: Temporarily disable gitops tests Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 8, 2026

@ggiguash: This pull request references USHIFT-6682 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Updated test configuration to modify the test suite execution.
  • Adjusted which tests run in the periodics workflow, removing gitops from the execution pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Mar 8, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 8, 2026

@ggiguash: This pull request references USHIFT-6682 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Updated periodic test scenario configuration to change the source reference used when creating VMs.
  • Adjusted test execution to run specific telemetry, cluster-id, and systemd tests directly (removed nested suite path).
  • Added TODO markers around VM creation and test-run steps to indicate follow-up work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Mar 8, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Mar 8, 2026

Storage test flake

/override ci/prow/e2e-aws-tests-bootc-arm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 8, 2026

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-arm

Details

In response to this:

Storage test flake

/override ci/prow/e2e-aws-tests-bootc-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 8, 2026

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cbd1f71 into openshift:main Mar 8, 2026
13 checks passed
@ggiguash ggiguash deleted the gitops-scenario-disable branch March 8, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants