USHIFT-6682: Reenable gitops test

[pmtk]

Summary by CodeRabbit

• Chores
  • Updated GitOps package version to 1.19 (was 1.16).
  • Adjusted test scenarios and boot-source configuration to support the updated GitOps flows.
  • Added a harmless, deprecated shim for script exit logging to maintain compatibility with existing tooling.

[pmtk]

/test ?

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

GITOPS_VERSION updated from 1.16 to 1.19 in version sources; a gitops-specific boot source and the suites/gitops/ test suite were added to a boot scenario script; a new no-op shim function log_script_exit() was added to packaging/greenboot/functions.sh.

Changes

Cohort / File(s)	Summary
Version Updates test/bin/common_versions.sh, test/bin/pyutils/generate_common_versions.py	Bumped GITOPS_VERSION from 1.16 to 1.19 (shell and Python).
Test Suite Configuration test/scenarios-bootc/periodics/el98-src@gitops-telemetry-clusterid-systemd.sh	Swapped rhel98-bootc-source for rhel98-bootc-source-gitops; added suites/gitops/ to run_tests; removed two TODO comment blocks.
Greenboot function packaging/greenboot/functions.sh	Added new no-op shim function log_script_exit() that prints a deprecation message and is a placeholder.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names	✅ Passed	PR does not modify Ginkgo test files with dynamic test names; Robot Framework tests use static descriptive names.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo test files; modifications are limited to configuration and utility scripts.
Title check	✅ Passed	The title 'USHIFT-6682: Reenable gitops test' directly relates to the main objective of re-enabling gitops tests by updating GITOPS_VERSION and adding test suite configurations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pmtk]

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm

[coderabbitai]

🧹 Nitpick comments (1)

packaging/greenboot/functions.sh (1)

142-144: Document that this is an intentional compatibility shim.

A bare no-op here is fine, but without a short comment explaining which caller expects log_script_exit(), this looks removable during cleanup. Please add one line clarifying that it exists to satisfy the gitops script hook.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packaging/greenboot/functions.sh` around lines 142 - 144, Add a one-line
comment to the no-op function log_script_exit clarifying it is an intentional
compatibility shim kept to satisfy the gitops script hook (i.e., a caller
outside this module expects this function), so it isn't removed during cleanup;
place the brief comment immediately above or inside the log_script_exit function
body mentioning "compat shim for gitops script hook" and leave the function body
as a no-op.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packaging/greenboot/functions.sh`:
- Around line 142-144: Add a one-line comment to the no-op function
log_script_exit clarifying it is an intentional compatibility shim kept to
satisfy the gitops script hook (i.e., a caller outside this module expects this
function), so it isn't removed during cleanup; place the brief comment
immediately above or inside the log_script_exit function body mentioning "compat
shim for gitops script hook" and leave the function body as a no-op.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c7688848-63ca-4046-b2a3-497dedaa94b2

📥 Commits

Reviewing files that changed from the base of the PR and between 68cb883 and 5c4f981.

📒 Files selected for processing (1)

• packaging/greenboot/functions.sh

[pmtk]

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-6682 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

• Chores
• Updated GitOps package version to 1.19 (was 1.16).
• Adjusted test scenarios and boot-source configuration to support the updated GitOps flows.
• Added a harmless, deprecated shim for script exit logging to maintain compatibility with existing tooling.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pmtk]

/verified by ci

[openshift-ci-robot]

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pmtk]

/retest

[ggiguash]

/retest-required

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.