USHIFT-6692: Update jira to atlassian#6359
USHIFT-6692: Update jira to atlassian#6359openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
@agullon could you please help review ? thanks !! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughReplaced Jira-specific environment/config with Atlassian equivalents in docs and code: README and advisory_publication_report.py now use ATLASSIAN_URL, ATLASSIAN_API_TOKEN, and ATLASSIAN_EMAIL; Jira client creation moved to get_jira_server(); ticket search function now accepts an external Jira server parameter. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/advisory_publication/advisory_publication_report.py`:
- Line 31: Fix the typo in the usage/help text by replacing the incorrect string
"ATTLASIAN_API_TOKEN" with the correct environment variable name
"ATLASSIAN_API_TOKEN"; locate the occurrence of "ATTLASIAN_API_TOKEN" in
advisory_publication_report.py (the usage/description text) and update it so any
help output, docs, or env var references use "ATLASSIAN_API_TOKEN" consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 47a89490-c966-4e08-ad70-c33b2ae49072
📒 Files selected for processing (2)
scripts/advisory_publication/README.mdscripts/advisory_publication/advisory_publication_report.py
kasturinarra
changed the title
kasturinarra
changed the title
|
@kasturinarra: An error was encountered searching for bug USHIFT-6692 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 403:
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
scripts/advisory_publication/README.md (1)
30-38: Update the section title to match the new token name.Line 30 still says “Jira API token” while Lines 35 and 38 use
ATLASSIAN_API_TOKEN. This is inconsistent and can confuse setup.Suggested fix
-### Jira API token +### Atlassian API tokenAs per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/advisory_publication/README.md` around lines 30 - 38, Rename the section header currently reading "Jira API token" to match the environment variable and product name used in the content—e.g., change the heading to "Atlassian API token" or "ATLASSIAN_API_TOKEN" so it consistently references ATLASSIAN_API_TOKEN used in the example export command; update the heading text where "Jira API token" appears to this new title.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/advisory_publication/README.md`:
- Around line 37-39: The fenced code block containing export
ATLASSIAN_API_TOKEN="TOKEN_VALUE" is missing a language tag (MD040); update the
opening fence from ``` to ```bash so the block is explicitly marked as bash/sh
and will be syntax-highlighted and lint-clean (locate the block that contains
export ATLASSIAN_API_TOKEN="TOKEN_VALUE" and change the opening backticks to
```bash).
---
Nitpick comments:
In `@scripts/advisory_publication/README.md`:
- Around line 30-38: Rename the section header currently reading "Jira API
token" to match the environment variable and product name used in the
content—e.g., change the heading to "Atlassian API token" or
"ATLASSIAN_API_TOKEN" so it consistently references ATLASSIAN_API_TOKEN used in
the example export command; update the heading text where "Jira API token"
appears to this new title.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 499d79be-2983-40ae-a146-04f10a030f02
📒 Files selected for processing (1)
scripts/advisory_publication/README.md
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
scripts/advisory_publication/README.md (1)
36-39:⚠️ Potential issue | 🟡 MinorAdd a language to the fenced shell block.
Line 36 opens a fenced block without a language, which still triggers markdownlint MD040.
Suggested fix
-``` +```bash export ATLASSIAN_API_TOKEN="TOKEN_VALUE" export ATLASSIAN_EMAIL="your-email@redhat.com"</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@scripts/advisory_publication/README.mdaround lines 36 - 39, Add a language
identifier to the fenced code block that sets environment variables so
markdownlint MD040 is satisfied: locate the fenced block containing the two
export lines (export ATLASSIAN_API_TOKEN and export ATLASSIAN_EMAIL) in the
README and change the opening fence to include "bash" (i.e., ```bash) so the
block is explicitly marked as shell script.</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against the current code and only fix it if needed.
Inline comments:
In@scripts/advisory_publication/advisory_publication_report.py:
- Around line 281-286: The current conditional only treats None as missing for
ATLASSIAN_API_TOKEN, ATLASSIAN_EMAIL, and GITLAB_API_TOKEN, so empty strings
slip through; update the check and each subsequent per-variable test to treat
empty/whitespace-only values as missing (e.g., use a falsy/strip check) when
populating missing_tokens in the if block that references ATLASSIAN_API_TOKEN,
ATLASSIAN_EMAIL and GITLAB_API_TOKEN so empty env vars are appended to
missing_tokens the same as None.
Duplicate comments:
In@scripts/advisory_publication/README.md:
- Around line 36-39: Add a language identifier to the fenced code block that
sets environment variables so markdownlint MD040 is satisfied: locate the fenced
block containing the two export lines (export ATLASSIAN_API_TOKEN and export
ATLASSIAN_EMAIL) in the README and change the opening fence to include "bash"
(i.e., ```bash) so the block is explicitly marked as shell script.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Repository YAML (base), Organization UI (inherited) **Review profile**: CHILL **Plan**: Pro **Run ID**: `b4f09c2f-4780-4d49-8e9a-8496f9534751` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 25df628e272cadcd3190b01ab0d3a2fbce06f947 and 95ee323780932ec692b814201924f9983f176486. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `scripts/advisory_publication/README.md` * `scripts/advisory_publication/advisory_publication_report.py` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
♻️ Duplicate comments (1)
scripts/advisory_publication/README.md (1)
36-39:⚠️ Potential issue | 🟡 MinorAdd language specifier to fenced code block.
The code block is missing a language identifier (
bash).-``` +```bash export ATLASSIAN_API_TOKEN="TOKEN_VALUE" export ATLASSIAN_EMAIL="your-email@redhat.com"<details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@scripts/advisory_publication/README.mdaround lines 36 - 39, The fenced code
block containing the export statements for ATLASSIAN_API_TOKEN and
ATLASSIAN_EMAIL should include a language specifier; update the block opening
fromtobash so it reads as a bash code block, e.g., change the fence
above the lines "export ATLASSIAN_API_TOKEN="TOKEN_VALUE"" and "export
ATLASSIAN_EMAIL="your-email@redhat.com"" to ```bash to enable proper syntax
highlighting.</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In@scripts/advisory_publication/README.md:
- Around line 36-39: The fenced code block containing the export statements for
ATLASSIAN_API_TOKEN and ATLASSIAN_EMAIL should include a language specifier;
update the block opening fromtobash so it reads as a bash code block,
e.g., change the fence above the lines "export
ATLASSIAN_API_TOKEN="TOKEN_VALUE"" and "export
ATLASSIAN_EMAIL="your-email@redhat.com"" to ```bash to enable proper syntax
highlighting.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Repository YAML (base), Organization UI (inherited) **Review profile**: CHILL **Plan**: Pro **Run ID**: `ddf560a2-84ca-4aa3-b96f-e52c75f56360` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 95ee323780932ec692b814201924f9983f176486 and 2334056775119c7cebefd635e8eb85cd14d00a38. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `scripts/advisory_publication/README.md` * `scripts/advisory_publication/advisory_publication_report.py` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/override ci/prow/e2e-aws-tests |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@kasturinarra: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.19 |
|
@kasturinarra: #6359 failed to apply on top of branch "release-4.19": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Migrated from jira to atlassian