Skip to content

NO-ISSUE: Fix 'git add -A' in pyutils/gitutils.py#6364

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:fix-pyutils-git-add-all
Mar 17, 2026
Merged

NO-ISSUE: Fix 'git add -A' in pyutils/gitutils.py#6364
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:fix-pyutils-git-add-all

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Mar 17, 2026

No description provided.

@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f63bebb4-35de-4018-800c-9e494f580785

📥 Commits

Reviewing files that changed from the base of the PR and between 302a842 and c031961.

📒 Files selected for processing (1)
  • scripts/pyutils/gitutils.py

Walkthrough

Changed the method of staging all files in scripts/pyutils/gitutils.py from GitPython's high-level index.add(A=True) to invoking the lower-level git add -A command via Repo.git interface. No logic or error handling modifications.

Changes

Cohort / File(s) Summary
Staging method update
scripts/pyutils/gitutils.py
Replaced index.add(A=True) with direct git add -A command invocation via Repo.git interface for staging all changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

@openshift-ci openshift-ci bot requested review from jogeo and vanhalenar March 17, 2026 06:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2026

/test ?

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2026

/test test-rebase

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2026

/verify by ci

@copejon
Copy link
Contributor

copejon commented Mar 17, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026
@openshift-ci-robot
Copy link

@copejon: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0027601 into openshift:main Mar 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants