Skip to content

USHIFT-6708: Fix dnf_retry.sh to be more robust to package list separators#6365

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:dnf-retry-fix
Mar 17, 2026
Merged

USHIFT-6708: Fix dnf_retry.sh to be more robust to package list separators#6365
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:dnf-retry-fix

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Mar 17, 2026

@openshift-ci openshift-ci bot requested review from agullon and eslutsky March 17, 2026 08:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 264ccf3f-c1c0-4e35-971b-bbc0872d6d3a

📥 Commits

Reviewing files that changed from the base of the PR and between 302a842 and 44628df.

📒 Files selected for processing (1)
  • scripts/dnf_retry.sh

Walkthrough

Modified scripts/dnf_retry.sh to change package argument construction. The script now iterates over individual package words from the DNF_PACK variable and appends each as a separate argument to DNF_CMD, rather than appending the entire array at once.

Changes

Cohort / File(s) Summary
DNF Package Handling
scripts/dnf_retry.sh
Modified loop logic to iterate over each package word individually and append as separate arguments to the DNF command, changing argument semantics for space-separated values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@ggiguash
Copy link
Contributor Author

/test ?

@ggiguash
Copy link
Contributor Author

/test e2e-aws-ai-model-serving
/test e2e-aws-footprint-and-performance

@ggiguash ggiguash changed the title Fix dnf_retry.sh to be more robust to package list separators USHIFT-6708: Fix dnf_retry.sh to be more robust to package list separators Mar 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2026

@ggiguash: This pull request references USHIFT-6708 which is a valid jira issue.

Details

In response to this:

Introduced by a0492bb

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c46ae08 into openshift:main Mar 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants