[release-4.21] OCPBUGS-78707: Feature gate lists can be set when FeatureSet is empty by copejon · Pull Request #6369 · openshift/microshift

copejon · 2026-03-17T15:45:45Z

Summary

Add validation to ensure CustomNoUpgrade and SpecialHandlingSupportExceptionRequired enabled/disabled lists are empty when FeatureSet is empty
Prevents invalid configurations and improves error handling for feature gate validation
Includes comprehensive test cases to verify the new validation logic

Changes

Added validation rule add remaining cert locations #7 to validateFeatureGates() function
Added error checking for non-empty CustomNoUpgrade and SpecialHandlingSupportExceptionRequired lists when FeatureSet is empty
Added test cases covering both CustomNoUpgrade and SpecialHandlingSupportExceptionRequired scenarios

Test plan

Unit tests added for both validation scenarios
Existing tests continue to pass
Validation correctly rejects invalid configurations
Valid configurations continue to work as expected

Fixes: OCPBUGS-78594

Made with Cursor

openshift-ci-robot · 2026-03-17T15:45:55Z

@copejon: This pull request references Jira Issue OCPBUGS-78594, which is invalid:

expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78594 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Add validation to ensure CustomNoUpgrade and SpecialHandlingSupportExceptionRequired enabled/disabled lists are empty when FeatureSet is empty

Prevents invalid configurations and improves error handling for feature gate validation

Includes comprehensive test cases to verify the new validation logic

Changes

Added validation rule add remaining cert locations #7 to validateFeatureGates() function

Added error checking for non-empty CustomNoUpgrade and SpecialHandlingSupportExceptionRequired lists when FeatureSet is empty

Added test cases covering both CustomNoUpgrade and SpecialHandlingSupportExceptionRequired scenarios

Test plan

Unit tests added for both validation scenarios

Existing tests continue to pass

Validation correctly rejects invalid configurations

Valid configurations continue to work as expected

Fixes: OCPBUGS-78594

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-17T15:45:55Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ade7770f-f2c1-4b7e-95d1-f03b82becaf3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

agullon · 2026-03-17T16:00:27Z

/label backport-risk-assessed
/verified by @agullon

agullon · 2026-03-17T16:00:37Z

/lgtm

openshift-ci-robot · 2026-03-17T16:00:42Z

@agullon: This PR has been marked as verified by @agullon.

Details

In response to this:

/label backport-risk-assessed
/verified by @agullon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-03-17T16:16:55Z

/label ?

openshift-ci · 2026-03-17T16:17:03Z

@agullon: The label(s) /label ? cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Add validation to ensure CustomNoUpgrade and SpecialHandlingSupportExceptionRequired enabled/disabled lists are empty when FeatureSet is empty. This prevents invalid configurations and improves error handling for feature gate validation. (cherry picked from commit <original-commit-hash>) Made-with: Cursor

agullon · 2026-03-17T16:26:22Z

/retitle "[release-4.21] OCPBUGS-78707: Feature gate lists can be set when FeatureSet is empty"

openshift-ci-robot · 2026-03-17T16:26:37Z

@copejon: This pull request references Jira Issue OCPBUGS-78707, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78707 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Add validation to ensure CustomNoUpgrade and SpecialHandlingSupportExceptionRequired enabled/disabled lists are empty when FeatureSet is empty

Prevents invalid configurations and improves error handling for feature gate validation

Includes comprehensive test cases to verify the new validation logic

Changes

Added validation rule add remaining cert locations #7 to validateFeatureGates() function

Added error checking for non-empty CustomNoUpgrade and SpecialHandlingSupportExceptionRequired lists when FeatureSet is empty

Added test cases covering both CustomNoUpgrade and SpecialHandlingSupportExceptionRequired scenarios

Test plan

Unit tests added for both validation scenarios

Existing tests continue to pass

Validation correctly rejects invalid configurations

Valid configurations continue to work as expected

Fixes: OCPBUGS-78594

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-03-17T16:26:51Z

/retitle [release-4.21] OCPBUGS-78707: Feature gate lists can be set when FeatureSet is empty

agullon · 2026-03-17T16:27:15Z

/jira refresh

openshift-ci-robot · 2026-03-17T16:27:21Z

@agullon: This pull request references Jira Issue OCPBUGS-78707, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78707 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-03-17T16:33:08Z

/jira refresh

openshift-ci-robot · 2026-03-17T16:33:17Z

@agullon: This pull request references Jira Issue OCPBUGS-78707, which is invalid:

expected Jira Issue OCPBUGS-78707 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-03-17T16:33:52Z

/lgtm

openshift-ci · 2026-03-17T16:34:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, copejon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [agullon,copejon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agullon · 2026-03-17T16:35:24Z

/jira refresh

openshift-ci-robot · 2026-03-17T16:35:34Z

@agullon: This pull request references Jira Issue OCPBUGS-78707, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-78594 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-78594 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-03-17T16:35:44Z

/verfied by CI and @agullon

agullon · 2026-03-17T16:40:33Z

/verified by CI and @agullon

openshift-ci-robot · 2026-03-17T16:40:49Z

@agullon: This PR has been marked as verified by CI and @agullon.

Details

In response to this:

/verified by CI and @agullon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-17T18:40:12Z

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-03-17T18:42:55Z

@copejon: Jira Issue OCPBUGS-78707: All pull requests linked via external trackers have merged:

openshift/microshift#6369

All linked pull requests have the verified tag. Jira Issue OCPBUGS-78707 has been moved to the VERIFIED state.

Details

In response to this:

Summary

Add validation to ensure CustomNoUpgrade and SpecialHandlingSupportExceptionRequired enabled/disabled lists are empty when FeatureSet is empty

Prevents invalid configurations and improves error handling for feature gate validation

Includes comprehensive test cases to verify the new validation logic

Changes

Added validation rule add remaining cert locations #7 to validateFeatureGates() function

Added error checking for non-empty CustomNoUpgrade and SpecialHandlingSupportExceptionRequired lists when FeatureSet is empty

Added test cases covering both CustomNoUpgrade and SpecialHandlingSupportExceptionRequired scenarios

Test plan

Unit tests added for both validation scenarios

Existing tests continue to pass

Validation correctly rejects invalid configurations

Valid configurations continue to work as expected

Fixes: OCPBUGS-78594

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot requested review from ggiguash and pmtk March 17, 2026 15:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 17, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026

openshift-ci bot assigned agullon Mar 17, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026

copejon changed the title ~~OCPBUGS-78594: Validate FeatureGates when FeatureSet is empty~~ [release-4.21] OCPBUGS-78594: Validate FeatureGates when FeatureSet is empty Mar 17, 2026

copejon force-pushed the ocpbugs-78594-cherry-pick branch from aba3ad6 to 9ff22dc Compare March 17, 2026 16:23

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026

openshift-ci bot changed the title ~~[release-4.21] OCPBUGS-78594: Validate FeatureGates when FeatureSet is empty~~ "[release-4.21] OCPBUGS-78707: Feature gate lists can be set when FeatureSet is empty" Mar 17, 2026

openshift-ci bot changed the title ~~"[release-4.21] OCPBUGS-78707: Feature gate lists can be set when FeatureSet is empty"~~ [release-4.21] OCPBUGS-78707: Feature gate lists can be set when FeatureSet is empty Mar 17, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026

openshift-merge-bot bot merged commit 5786c91 into openshift:release-4.21 Mar 17, 2026
13 checks passed

Conversation

copejon commented Mar 17, 2026

Summary

Changes

Test plan

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Summary

Changes

Test plan

Uh oh!

coderabbitai bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci bot commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Summary

Changes

Test plan

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci bot commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

agullon commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

openshift-ci bot commented Mar 17, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Summary

Changes

Test plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 17, 2026 •

edited

Loading