Skip to content

USHIFT-6765: Add author filter to microshift-prow-jobs-for-pull-requests.sh#6433

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
ggiguash:fix-pr-filtering-script
Mar 31, 2026
Merged

USHIFT-6765: Add author filter to microshift-prow-jobs-for-pull-requests.sh#6433
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
ggiguash:fix-pr-filtering-script

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

Required for more deterministic filtering of issues based on actual GitHub user names rather than title strings.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

@ggiguash: This pull request references USHIFT-6765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Required for more deterministic filtering of issues based on actual GitHub user names rather than title strings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6477c82a-26b9-43c2-b94b-5d580acb0c90

📥 Commits

Reviewing files that changed from the base of the PR and between 20d234d and 5a9b122.

📒 Files selected for processing (1)
  • .claude/scripts/microshift-prow-jobs-for-pull-requests.sh

Walkthrough

Adds an optional GitHub author filter to the microshift prow jobs script, extending CLI and mode functions to accept and forward an --author argument; updates documentation to use author-based rebase filtering for the analyze-ci pull-requests command.

Changes

Cohort / File(s) Summary
Script: author filtering
.claude/scripts/microshift-prow-jobs-for-pull-requests.sh
Added --author USER CLI option and validation; changed fetch_open_prs(filter)fetch_open_prs(filter, author) and updated mode_summary, mode_detail, mode_approve, mode_restart signatures and calls to accept and forward author; PR listing includes conditional --author argument.
Docs: rebase filter update
.claude/commands/analyze-ci/pull-requests.md
Replaced title-based --filter rebase selection with author-based selection (microshift-rebase-script[bot]) in examples and behavior text.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from pacevedom and vanhalenar March 31, 2026 05:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.claude/scripts/microshift-prow-jobs-for-pull-requests.sh (1)

19-19: Quote the --json field list for clarity and lint cleanliness.

Line 19 works as-is, but quoting number,title,url makes it explicit this is one argument and avoids ShellCheck SC2054 noise.

Suggested tweak
-    local -a gh_args=(--repo "${GH_REPO}" --state open --limit 100 --json number,title,url)
+    local -a gh_args=(--repo "${GH_REPO}" --state open --limit 100 --json "number,title,url")
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude/scripts/microshift-prow-jobs-for-pull-requests.sh at line 19, The
gh_args array currently passes the --json fields unquoted which can trigger
ShellCheck SC2054 and is less explicit; update the local array assignment for
gh_args so the --json option and its comma-separated field list are a single
quoted argument (i.e., make --json "number,title,url") so that the JSON fields
are treated as one argument when building gh_args and avoid word-splitting
issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.claude/scripts/microshift-prow-jobs-for-pull-requests.sh:
- Line 19: The gh_args array currently passes the --json fields unquoted which
can trigger ShellCheck SC2054 and is less explicit; update the local array
assignment for gh_args so the --json option and its comma-separated field list
are a single quoted argument (i.e., make --json "number,title,url") so that the
JSON fields are treated as one argument when building gh_args and avoid
word-splitting issues.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b10138ec-d559-4e9e-8cb4-7c7a68ac0449

📥 Commits

Reviewing files that changed from the base of the PR and between b5e9d9c and 2bb2c0e.

📒 Files selected for processing (1)
  • .claude/scripts/microshift-prow-jobs-for-pull-requests.sh

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Mar 31, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/verified by @ggiguash

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by @ggiguash.

Details

In response to this:

/verified by @ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 687d05e into openshift:main Mar 31, 2026
7 checks passed
@ggiguash ggiguash deleted the fix-pr-filtering-script branch March 31, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants