USHIFT-6765: Add author filter to microshift-prow-jobs-for-pull-requests.sh#6433
Conversation
|
@ggiguash: This pull request references USHIFT-6765 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds an optional GitHub author filter to the microshift prow jobs script, extending CLI and mode functions to accept and forward an Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.claude/scripts/microshift-prow-jobs-for-pull-requests.sh (1)
19-19: Quote the--jsonfield list for clarity and lint cleanliness.Line 19 works as-is, but quoting
number,title,urlmakes it explicit this is one argument and avoids ShellCheck SC2054 noise.Suggested tweak
- local -a gh_args=(--repo "${GH_REPO}" --state open --limit 100 --json number,title,url) + local -a gh_args=(--repo "${GH_REPO}" --state open --limit 100 --json "number,title,url")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/scripts/microshift-prow-jobs-for-pull-requests.sh at line 19, The gh_args array currently passes the --json fields unquoted which can trigger ShellCheck SC2054 and is less explicit; update the local array assignment for gh_args so the --json option and its comma-separated field list are a single quoted argument (i.e., make --json "number,title,url") so that the JSON fields are treated as one argument when building gh_args and avoid word-splitting issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.claude/scripts/microshift-prow-jobs-for-pull-requests.sh:
- Line 19: The gh_args array currently passes the --json fields unquoted which
can trigger ShellCheck SC2054 and is less explicit; update the local array
assignment for gh_args so the --json option and its comma-separated field list
are a single quoted argument (i.e., make --json "number,title,url") so that the
JSON fields are treated as one argument when building gh_args and avoid
word-splitting issues.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b10138ec-d559-4e9e-8cb4-7c7a68ac0449
📒 Files selected for processing (1)
.claude/scripts/microshift-prow-jobs-for-pull-requests.sh
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @ggiguash |
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Required for more deterministic filtering of issues based on actual GitHub user names rather than title strings.