test: explicitly process bootc templates#6486
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdded a pre-build templating step in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@copejon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ofile = os.path.join(BOOTC_IMAGE_DIR, ifile) | ||
| ifile = os.path.join(ipkgdir, ifile) | ||
| run_template_cmd(ifile, ofile, args.dry_run) | ||
| # Process shared bootc templates (USHIFT-6788) |
There was a problem hiding this comment.
Please remove the issue ID from the comment. We do not usually do this unless it's a TODO item.
| run_template_cmd(ifile, ofile, args.dry_run) | ||
| # Process shared bootc templates (USHIFT-6788) | ||
| tpldir = f"{SCRIPTDIR}/../image-blueprints-bootc/templates" | ||
| if os.path.isdir(tpldir): |
There was a problem hiding this comment.
This code is almost a duplicate of a block from process_group function.
Let's refactor it into process_template_files and call from both places?
Summary
image-blueprints-bootc/templates/directoryFixes: USHIFT-6788
Test plan
🤖 Generated with Claude Code