USHIFT-6774: Leave VM ready after tuned suite

[pmtk]

Summary by CodeRabbit

• Tests
  • Improved test suite reliability by adding a post-restart system health verification step to ensure proper recovery before completing teardown operations.

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-6774 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d046278-2671-4813-9f18-a481de6d4b0f

📥 Commits

Reviewing files that changed from the base of the PR and between bbad4d6 and 263e15c.

📒 Files selected for processing (1)

• test/suites/tuned/microshift-tuned.robot

---

Walkthrough

A wait step for MicroShift healthcheck success was added to the Teardown keyword in the microshift-tuned test suite, executed after re-enabling MicroShift and restarting the microshift-tuned service.

Changes

Cohort / File(s)	Summary
Test Teardown Enhancement test/suites/tuned/microshift-tuned.robot	Added Wait For MicroShift Healthcheck Success step in Teardown keyword following MicroShift re-enablement and service restart.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding a wait step in teardown to ensure the VM is ready after the tuned suite completes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	PR modifies only Robot Framework tests with static descriptive names; Ginkgo check is inapplicable and passes by default.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code is not applicable to Robot Framework test files.
Microshift Test Compatibility	✅ Passed	PR modifies only a Robot Framework test file, not Ginkgo e2e tests. The custom check targets Ginkgo e2e tests for MicroShift API compatibility, which are not introduced here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request modifies a Robot Framework test file, not a Ginkgo e2e test. The SNO Test Compatibility check applies only to Ginkgo e2e tests with Go test declarations, which are absent here.
Topology-Aware Scheduling Compatibility	✅ Passed	Custom check for topology-aware scheduling compatibility is not applicable. The modified file is a Robot Framework test automation file adding a wait step in test teardown logic, containing neither deployment manifests, operator code, nor controllers.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is inapplicable to this pull request, which only modifies a Robot Framework test file with no JSON stdout communication requirements.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies Robot Framework test file, not Ginkgo e2e test. Custom check for IPv6 and disconnected network compatibility does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-6774 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

• Tests
• Improved test suite reliability by adding a post-restart system health verification step to ensure proper recovery before completing teardown operations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pmtk]

/verified by ci

[openshift-ci-robot]

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pmtk]

/cherry-pick release-4.22

[pmtk]

/cherrypick release-4.22

[openshift-cherrypick-robot]

@pmtk: new pull request created: #6542

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@pmtk: new pull request could not be created: failed to create pull request against openshift/microshift#release-4.22 from head openshift-cherrypick-robot:cherry-pick-6521-to-release-4.22: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-6521-to-release-4.22."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherrypick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.