Skip to content

USHIFT-6986: Add retry and error handling to cfssl downloads in CNCF …#6698

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
pacevedom:USHIFT-6986
May 24, 2026
Merged

USHIFT-6986: Add retry and error handling to cfssl downloads in CNCF …#6698
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
pacevedom:USHIFT-6986

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

…conformance

The cfssl binary downloads in configure-pri.sh intermittently fail due to transient network issues, causing silent checksum mismatches because curl saves error responses as the output file.

Add --fail to reject HTTP errors, --retry with --retry-all-errors for resilience, and -S to surface errors in logs for debugging.

…conformance

The cfssl binary downloads in configure-pri.sh intermittently fail
due to transient network issues, causing silent checksum mismatches
because curl saves error responses as the output file.

Add --fail to reject HTTP errors, --retry with --retry-all-errors
for resilience, and -S to surface errors in logs for debugging.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 19, 2026

@pacevedom: This pull request references USHIFT-6986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.z" version, but no target version was set.

Details

In response to this:

…conformance

The cfssl binary downloads in configure-pri.sh intermittently fail due to transient network issues, causing silent checksum mismatches because curl saves error responses as the output file.

Add --fail to reject HTTP errors, --retry with --retry-all-errors for resilience, and -S to surface errors in logs for debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 89d78014-08aa-46fa-8935-da198478fbe8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from copejon and pmtk May 19, 2026 08:43
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

@copejon
Copy link
Copy Markdown
Contributor

copejon commented May 19, 2026

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

@pacevedom
Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-aws-tests-bootc
/override ci/prow/e2e-aws-tests-bootc-arm

The changes in this PR only impact cncf conformance tests, which are not present in the failures seen above, therefore its an unrelated error.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-arm

Details

In response to this:

/override ci/prow/e2e-aws-tests-bootc
/override ci/prow/e2e-aws-tests-bootc-arm

The changes in this PR only impact cncf conformance tests, which are not present in the failures seen above, therefore its an unrelated error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@pacevedom: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/label jira/valid-bug
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 23, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 23, 2026

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc 2ca3edc link true /test e2e-aws-tests-bootc
ci/prow/e2e-aws-tests-bootc-arm 2ca3edc link true /test e2e-aws-tests-bootc-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 9552c3d into openshift:release-4.19 May 24, 2026
11 checks passed
@pacevedom
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pacevedom: new pull request created: #6726

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants