USHIFT-6528: Switch to RHEL 9.8 production registry for bootc images

[agullon]

Update published-images test scenarios from RHEL 9.6 (EL96) to RHEL 9.8 (EL98).

Changes:

• Replace el96-lrel@published-images-standard1.sh with el98-lrel@published-images-standard1.sh
• Replace el96-lrel@published-images-standard2.sh with el98-lrel@published-images-standard2.sh
• Update VM name: rhel96-bootc → rhel98-bootc
• Update expected OS version: 9.6 → 9.8 (standard1 scenario)

Both scenarios maintain signature verification for published MicroShift images and follow the same testing pattern as their EL96 predecessors.

Related PR:

• release-4.22: [release-4.22] USHIFT-6528: Switch to RHEL 9.8 production registry for bootc images #6775

Summary by CodeRabbit

• Tests
  • Updated test scenarios to support validation of RHEL 9.8 bootc container images
  • Enhanced test infrastructure with OS version verification for the latest RHEL 9.8 releases
  • Maintained all existing test logic for image resolution, firewall configuration, and signature validation

[coderabbitai]

Walkthrough

Test scenario scripts for RHEL 9.8 bootc are updated to launch the rhel98-bootc VM image instead of rhel96-bootc, and the expected OS version test parameter is updated from 9.6 to 9.8.

Changes

RHEL 9.8 Scenario Test Updates

Layer / File(s)	Summary
Test scenario VM and version updates test/scenarios-bootc/el9/releases/el98-lrel@published-images-standard1.sh, test/scenarios-bootc/el9/releases/el98-lrel@published-images-standard2.sh	Both scenario scripts now launch rhel98-bootc VM instead of rhel96-bootc. Standard1 also updates the EXPECTED_OS_VERSION test variable to 9.8 instead of 9.6.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	⚠️ Warning	The title mentions 'RHEL 9.8 production registry' but the changes are about updating test scenarios from EL96 to EL98, not switching registries.	Revise title to accurately reflect the change: 'Replace EL96 with EL98 in published-images test scenarios' or similar.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR changes are Bash scenario scripts (not Ginkgo tests). They define shell functions (scenario_create_vms, scenario_remove_vms, scenario_run_tests), not Ginkgo test definitions.
Test Structure And Quality	✅ Passed	PR contains only Bash scenario scripts, not Ginkgo test code. Custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility	✅ Passed	PR modifies only Bash scenario scripts, not Ginkgo e2e tests. No new Ginkgo test code (It, Describe, Context, When patterns) detected.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR contains only bash scenario configuration scripts updating EL96 to EL98, not new Ginkgo e2e tests that require SNO compatibility review.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only bash test scenario scripts that set up test VMs. No deployment manifests, operator code, or Kubernetes scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only Bash scenario scripts in test/scenarios-bootc/el9/releases/, not OTE binary code. Custom check is inapplicable as it targets Go process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies Bash scenario shell scripts, not Ginkgo e2e tests. The custom check applies only to new Ginkgo tests (It(), Describe(), etc.), which are not present in these changes.
No-Weak-Crypto	✅ Passed	No weak cryptography patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant-time secret comparisons detected in the modified test scenario scripts.
Container-Privileges	✅ Passed	The PR changes only bash test scenario scripts with no container/K8s manifest definitions, making the container-privileges check not applicable.
No-Sensitive-Data-In-Logs	✅ Passed	The two EL98 scenario files contain no logging statements exposing passwords, tokens, API keys, PII, session IDs, or sensitive data. Only safe configuration variables and function calls are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@agullon: This pull request references USHIFT-6528 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "openshift-4.22" instead.

Details

In response to this:

Update published-images test scenarios from RHEL 9.6 (EL96) to RHEL 9.8 (EL98).

Changes:

• Replace el96-lrel@published-images-standard1.sh with el98-lrel@published-images-standard1.sh
• Replace el96-lrel@published-images-standard2.sh with el98-lrel@published-images-standard2.sh
• Update VM name: rhel96-bootc → rhel98-bootc
• Update expected OS version: 9.6 → 9.8 (standard1 scenario)

Both scenarios maintain signature verification for published MicroShift images and follow the same testing pattern as their EL96 predecessors.

Related PR:

• release-4.22: [release-4.22] USHIFT-6528: Switch to RHEL 9.8 production registry for bootc images #6775

Summary by CodeRabbit

• Tests
• Updated test scenarios to support validation of RHEL 9.8 bootc container images
• Enhanced test infrastructure with OS version verification for the latest RHEL 9.8 releases
• Maintained all existing test logic for image resolution, firewall configuration, and signature validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[agullon]

/verified by CI

[openshift-ci-robot]

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [agullon,ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment