USHIFT-6401: Add per-attempt timeout to RBAC bootstrap hook#6784
USHIFT-6401: Add per-attempt timeout to RBAC bootstrap hook#6784copejon wants to merge 1 commit into
Conversation
Thread a 5s context.WithTimeout into each poll attempt of the RBAC bootstrap PostStartHook, preventing indefinite hangs when etcd is unresponsive during initial readiness checks. Replace context.TODO() with the deadline-scoped context in List calls and prime functions. Add a klog.Warningf on timeout to distinguish deadline exceeded from other transient errors. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@copejon: This pull request references USHIFT-6401 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@copejon: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-tests-bootc-release-arm-periodic-el9 |
|
@copejon: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
USHIFT-6401
This manual backport of #6635 is intended to test the solution on the release-4.22 branch because it historically has the highest occurrence of the ushift-6401 failures.