Skip to content

USHIFT-6401: Add per-attempt timeout to RBAC bootstrap hook#6816

Open
copejon wants to merge 1 commit into
openshift:release-4.22from
copejon:backport-USHIFT-6401-release-4.22
Open

USHIFT-6401: Add per-attempt timeout to RBAC bootstrap hook#6816
copejon wants to merge 1 commit into
openshift:release-4.22from
copejon:backport-USHIFT-6401-release-4.22

Conversation

@copejon
Copy link
Copy Markdown
Contributor

@copejon copejon commented Jun 7, 2026

Summary

  • Backport of #TBD (main) to release-4.22
  • Thread a 5s context.WithTimeout into each poll attempt of the RBAC bootstrap PostStartHook, preventing indefinite hangs when etcd is unresponsive during initial readiness checks
  • Replace context.TODO() with the deadline-scoped context in List calls and prime functions
  • Add klog.Warningf on timeout to distinguish deadline exceeded from other transient errors

Test plan

  • CI passes on release-4.22
  • Verify RBAC bootstrap completes normally on a clean MicroShift install
  • Verify timeout logging appears when etcd is delayed

🤖 Generated with Claude Code

Thread a 5s context.WithTimeout into each poll attempt of the RBAC
bootstrap PostStartHook, preventing indefinite hangs when etcd is
unresponsive during initial readiness checks. Replace context.TODO()
with the deadline-scoped context in List calls and prime functions.
Add a klog.Warningf on timeout to distinguish deadline exceeded from
other transient errors.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 7, 2026

@copejon: This pull request references USHIFT-6401 which is a valid jira issue.

Details

In response to this:

Summary

  • Backport of #TBD (main) to release-4.22
  • Thread a 5s context.WithTimeout into each poll attempt of the RBAC bootstrap PostStartHook, preventing indefinite hangs when etcd is unresponsive during initial readiness checks
  • Replace context.TODO() with the deadline-scoped context in List calls and prime functions
  • Add klog.Warningf on timeout to distinguish deadline exceeded from other transient errors

Test plan

  • CI passes on release-4.22
  • Verify RBAC bootstrap completes normally on a clean MicroShift install
  • Verify timeout logging appears when etcd is delayed

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fb5ef921-11dd-4b67-bfd7-bef3887d8b07

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from eslutsky and kasturinarra June 7, 2026 18:58
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2026

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants