-
Notifications
You must be signed in to change notification settings - Fork 223
Hello-world example manifests for microshift-hello-world app #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7485805 to
a75d1ce
Compare
a75d1ce to
331653e
Compare
|
@mangelajo can you provide a description of how this app will be used? A simple README in the packaging/hello-world folder so people can see what it is/why it's here/what it's for? Can be a follow-up, or even, I can write something up if you give me the info :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mangelajo, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mangelajo Can you create a jira ticket to track adding a CI workflow for the demo? We'll want to make sure it's always in a working state. |
|
I need to get back to this as soon as I finish the CNI investigations. |
|
/kind documentation |
|
@mangelajo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Moved this example to https://github.com/redhat-et/microshift-demos/tree/main/apps/hello-microshift. |
Can we add build.sh or an equivalent to the other repo? :-D |
It's here: https://github.com/redhat-et/microshift-demos/blob/main/apps/build_images |
|
ahh awesome!, somehow I didn't see it
…On Mon, Nov 28, 2022 at 3:01 PM Frank Zdarsky ***@***.***> wrote:
Can we add build.sh or an equivalent to the other repo? :-D
It's here:
https://github.com/redhat-et/microshift-demos/blob/main/apps/build_images
—
Reply to this email directly, view it on GitHub
<#688 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI7G4XBZL34BTY7BKEFURDWKS3MBANCNFSM5WFBYLCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Miguel Ángel Ajo @mangel_ajo <https://twitter.com/mangel_ajo>
Office of CTO EDGE team.
ex Submariner (ACM) and OpenStack networking
|
No description provided.