Skip to content

Conversation

@mangelajo
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from rootfs and sallyom May 17, 2022 14:04
@mangelajo mangelajo force-pushed the hello-world-app branch 2 times, most recently from 7485805 to a75d1ce Compare May 17, 2022 14:43
@sallyom
Copy link
Contributor

sallyom commented May 23, 2022

@mangelajo can you provide a description of how this app will be used? A simple README in the packaging/hello-world folder so people can see what it is/why it's here/what it's for? Can be a follow-up, or even, I can write something up if you give me the info :)

@sallyom
Copy link
Contributor

sallyom commented May 23, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@copejon
Copy link
Contributor

copejon commented May 25, 2022

@mangelajo Can you create a jira ticket to track adding a CI workflow for the demo? We'll want to make sure it's always in a working state.

@mangelajo
Copy link
Contributor Author

I need to get back to this as soon as I finish the CNI investigations.

@dhellmann
Copy link
Contributor

/kind documentation

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@mangelajo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodic-ocp-4.13-images 331653e link true /test periodic-ocp-4.13-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fzdarsky
Copy link
Contributor

Moved this example to https://github.com/redhat-et/microshift-demos/tree/main/apps/hello-microshift.

@fzdarsky fzdarsky closed this Nov 28, 2022
@mangelajo
Copy link
Contributor Author

Moved this example to https://github.com/redhat-et/microshift-demos/tree/main/apps/hello-microshift.

Can we add build.sh or an equivalent to the other repo? :-D

@fzdarsky
Copy link
Contributor

Can we add build.sh or an equivalent to the other repo? :-D

It's here: https://github.com/redhat-et/microshift-demos/blob/main/apps/build_images

@mangelajo
Copy link
Contributor Author

mangelajo commented Nov 28, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants