PERFSCALE-1818: Initial commit of ansible-microshift automation #847

sjug · 2022-08-09T16:23:16Z

Pre-localhost setup and logging setup
Add cadvisor to microshift node, run as service
Fix systemd_service var and apply firewall rules sooner
Manage prometheus config via template
Need to restart cadvisor after CRI-O starts in order to pick up the CRI-O container metrics
Split out EPEL repo install and add pbench agent tasks
Add pbench to README & pbench_env to vars
Set up pbench and kubectl
Make pbench-user-benchmark async
Updated inventory vars
Move API checks to remote node and automate pbench data collection
Write three stages of disk usage (pre-install, post-install, post-run) to file
Modify timing tasks: reorder and small fixes
New disk usage pattern + other small changes
Add warm start measurement
Rename install-localhost role to setup-localhost for clarity
Remove microshift state, unused local cluster state tracking
Move into ansible subdir
Add something to README.md

Which issue(s) this PR addresses:
This PR adds automation to measure the footprint and performance metrics of MicroShift via Ansible scripts.

- Pre-localhost setup and logging setup - Add cadvisor to microshift node, run as service - Fix systemd_service var and apply firewall rules sooner - Manage prometheus config via template - Need to restart cadvisor after CRI-O starts in order to pick up the CRI-O container metrics - Split out EPEL repo install and add pbench agent tasks - Add pbench to README & pbench_env to vars - Set up pbench and kubectl - Make pbench-user-benchmark async - Updated inventory vars - Move API checks to remote node and automate pbench data collection - Write three stages of disk usage (pre-install, post-install, post-run) to file - Modify timing tasks: reorder and small fixes - New disk usage pattern + other small changes - Add warm start measurement - Rename install-localhost role to setup-localhost for clarity - Remove microshift state, unused local cluster state tracking - Move into ansible subdir - Put something in README.md

dhellmann · 2022-08-10T13:18:49Z

Let's link this to the Jira ticket

/retitle PERFSCALE-1818: Initial commit of ansible-microshift automation

ansible/README.md

ansible/inventory/inventory

ansible/roles/epel-repo-install/tasks/main.yml

ansible/roles/install-logging/tasks/main.yml

ansible/roles/install-microshift/defaults/main.yml

ansible/roles/install-microshift/tasks/main.yml

ansible/roles/install-microshift/templates/kubernetes.repo.j2

ansible/inventory/inventory

ggiguash · 2022-08-16T07:03:13Z

Let's merge the first version of this change. I'm approving it and putting it on hold until @sjug feels convenient to release and merge it. Once merged, we should then discuss our next steps.
/hold
/lgtm

- Install oc client rather than kubectl

sjug · 2022-08-16T22:30:21Z

I've addressed pretty much all the review comments and we're in good shape for the most part.
Do you want me to squash and push one commit or do you squash merge?

ggiguash · 2022-08-17T12:57:05Z

/lgtm

openshift-ci · 2022-08-17T12:57:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sjug · 2022-08-17T13:27:28Z

/unhold

openshift-ci · 2022-08-17T13:41:41Z

@sjug: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot requested review from copejon and sallyom August 9, 2022 16:24

sjug force-pushed the add-ansible-microshift branch from 16a9879 to 92b57a8 Compare August 9, 2022 16:34

openshift-ci bot changed the title ~~Initial commit of ansible-microshift automation~~ PERFSCALE-1818: Initial commit of ansible-microshift automation Aug 10, 2022