Skip to content

Set node-role.kubernetes.io based on MicroShift roles#869

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:node-role
Aug 23, 2022
Merged

Set node-role.kubernetes.io based on MicroShift roles#869
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:node-role

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Aug 17, 2022

Which issue(s) this PR addresses:
Closes #661 USHIFT-28

Desc
Adds node labeling based on MicroShift roles. There's a slight difference between MicroShift's and kubelet's roles: control-plane vs controlplane, worker vs node

@openshift-ci openshift-ci bot requested review from copejon and sallyom August 17, 2022 16:24
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Aug 17, 2022

/assign @fzdarsky
/cc @benluddy @dhellmann

@oglok
Copy link
Copy Markdown
Contributor

oglok commented Aug 18, 2022

[root@maxwell ~]# oc --kubeconfig=kubeconfig-clusterbot get node
NAME                                       STATUS   ROLES                  AGE   VERSION
ci-ln-cw0ryxb-72292-nqblm-master-0         Ready    control-plane,master   30m   v1.24.0+da80cd0
ci-ln-cw0ryxb-72292-nqblm-master-1         Ready    control-plane,master   30m   v1.24.0+da80cd0
ci-ln-cw0ryxb-72292-nqblm-master-2         Ready    control-plane,master   30m   v1.24.0+da80cd0
ci-ln-cw0ryxb-72292-nqblm-worker-a-r5bqn   Ready    worker                 21m   v1.24.0+da80cd0
ci-ln-cw0ryxb-72292-nqblm-worker-b-868mp   Ready    worker                 21m   v1.24.0+da80cd0
ci-ln-cw0ryxb-72292-nqblm-worker-c-jcpbf   Ready    worker                 21m   v1.24.0+da80cd0

Let's go for the same labels that are present in OpenShift. @dhellmann

@dhellmann
Copy link
Copy Markdown
Contributor

Yes, let's be consistent with standalone OpenShift.

@dhellmann
Copy link
Copy Markdown
Contributor

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 21, 2022
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Aug 22, 2022

Added master

@dhellmann
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@oglok
Copy link
Copy Markdown
Contributor

oglok commented Aug 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, oglok, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 23, 2022

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit eec8d9f into openshift:main Aug 23, 2022
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Aug 23, 2022

Closes USHIFT-28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Microshift does not honor /etc/microshift/config.yaml roles array

6 participants