Skip to content

OBSINTA-777: [Incidents] Regression tests for firing alerts in Incidents #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

OBSINTA-777: [Incidents] Regression tests for firing alerts in Incidents #622

merged 1 commit into from
Nov 25, 2025
+368 −26

Conversation

@DavidRajnoha
Copy link
Contributor

@DavidRajnoha DavidRajnoha commented Oct 31, 2025

This PR adds regression tests to verify that alerts are not incorrectly marked as resolved due to stale timestamps or non-refreshing values.

Changes:

  • Added new E2E regression test suite (03-04.reg_e2e_firing_alerts.cy.ts)
  • Updated incident commands to support creating alerts with fixed names per test
  • Ensures proper alert state management and prevents false resolution detection

Test Coverage:

  • Validates that firing alerts maintain their state correctly
  • Tests against stale timestamp issues
  • Verifies alert refresh behavior

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2025 •
edited by openshift-ci bot
Loading

@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

This PR adds regression tests to verify that alerts are not incorrectly marked as resolved due to stale timestamps or non-refreshing values.

Changes:

  • Added new E2E regression test suite (03-04.reg_e2e_firing_alerts.cy.ts)
  • Updated incident commands to support creating alerts with fixed names per test
  • Ensures proper alert state management and prevents false resolution detection

Test Coverage:

  • Validates that firing alerts maintain their state correctly
  • Tests against stale timestamp issues
  • Verifies alert refresh behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidRajnoha DavidRajnoha marked this pull request as ready for review October 31, 2025 14:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
@openshift-ci openshift-ci bot requested review from jgbernalp and zhuje October 31, 2025 14:52
@zhuje
Copy link
Contributor

zhuje commented Nov 3, 2025

/retest

2 similar comments
@zhuje
Copy link
Contributor

zhuje commented Nov 4, 2025

/retest

@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 17, 2025

/retest

@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 17, 2025

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2025
@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 18, 2025

/retest

@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 20, 2025

/label ux-approved
/label qe-approved

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025 •
edited by openshift-ci bot
Loading

@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

This PR adds regression tests to verify that alerts are not incorrectly marked as resolved due to stale timestamps or non-refreshing values.

Changes:

  • Added new E2E regression test suite (03-04.reg_e2e_firing_alerts.cy.ts)
  • Updated incident commands to support creating alerts with fixed names per test
  • Ensures proper alert state management and prevents false resolution detection

Test Coverage:

  • Validates that firing alerts maintain their state correctly
  • Tests against stale timestamp issues
  • Verifies alert refresh behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025

/retest-required

Remaining retests: 0 against base HEAD 24e74e8 and 2 for PR HEAD 3f283d9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025

/retest-required

Remaining retests: 0 against base HEAD 29ca2f9 and 1 for PR HEAD 3f283d9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

/retest-required

Remaining retests: 0 against base HEAD 8298186 and 0 for PR HEAD 3f283d9 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

/hold

Revision 3f283d9 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@DavidRajnoha DavidRajnoha force-pushed the cypress-incidents-regressions-firing-alerts branch from 3f283d9 to 04ac083 Compare November 24, 2025 13:24
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@DavidRajnoha
Copy link
Contributor Author

DavidRajnoha commented Nov 24, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025 •
edited
Loading

@DavidRajnoha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3f283d9 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DavidRajnoha
test(cypress): Regression for Incidents - firing alerts
6b0b78b 
Tests that verifies that alerts are not marked as resolved based on
not refreshing values or requests with stale timestamp.

Updates the incidents commands for creation of an alert with fixed
name per test.
@DavidRajnoha DavidRajnoha force-pushed the cypress-incidents-regressions-firing-alerts branch from 04ac083 to 6b0b78b Compare November 25, 2025 10:36
@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 25, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidRajnoha, etmurasaki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 516050c into openshift:main Nov 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbernalp jgbernalp Awaiting requested review from jgbernalp

@zhuje zhuje Awaiting requested review from zhuje

Assignees

@etmurasaki etmurasaki

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidRajnoha @openshift-ci-robot @zhuje @etmurasaki