Skip to content

OU-356: fix specific translations and items without translations #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2025
Merged

OU-356: fix specific translations and items without translations #651

merged 1 commit into from
Nov 22, 2025
+59 −33

Conversation

@jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Nov 21, 2025

No description provided.

@jgbernalp jgbernalp requested a review from etmurasaki November 21, 2025 09:48
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025 •
edited by openshift-ci bot
Loading

@jgbernalp: This pull request references OU-356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@jgbernalp
Copy link
Contributor Author

jgbernalp commented Nov 21, 2025

/test e2e-aws-ovn

@PeterYurkovich
Copy link
Contributor

PeterYurkovich commented Nov 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 21, 2025 •
edited
Loading

Fixed in this PR:
OCPBUGS-19968 marked as dup
OCPBUGS-35244 marked as dup
OCPBUGS-35245 marked as dup
OCPBUGS-35246 marked as dup
OCPBUGS-35248 marked as dup
CNV-70882 marked as dup

@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 21, 2025

/retest

@jgbernalp
fix specific translations and items without translations
58709b7 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,etmurasaki,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 21, 2025

Fix in this PR:
OCPBUGS-27920 marked as dup

@etmurasaki
Copy link
Contributor

etmurasaki commented Nov 21, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025 •
edited by openshift-ci bot
Loading

@jgbernalp: This pull request references OU-356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

/retest-required

Remaining retests: 0 against base HEAD 3c3fe3b and 2 for PR HEAD 58709b7 in total

@jgbernalp
Copy link
Contributor Author

jgbernalp commented Nov 22, 2025

/test e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2025

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e37e1cd into openshift:main Nov 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etmurasaki etmurasaki Awaiting requested review from etmurasaki

@PeterYurkovich PeterYurkovich Awaiting requested review from PeterYurkovich

@zhuje zhuje Awaiting requested review from zhuje

Assignees

@etmurasaki etmurasaki

@PeterYurkovich PeterYurkovich

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgbernalp @openshift-ci-robot @PeterYurkovich @etmurasaki