Skip to content

NO-JIRA: feat: use esbuild-loader, add push manifest command to makefile #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 5, 2026
Merged

NO-JIRA: feat: use esbuild-loader, add push manifest command to makefile #713

openshift-merge-bot merged 1 commit into from
Jan 5, 2026
+707 −285

Conversation

@jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Jan 2, 2026

This PR:

  • Uses esbuild-loader to speed up prod builds and reduce memory consumption
  • Adds a command to publish the manifest created when building cross platform
  • Increases default nodejs memory for building

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 2, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 2, 2026

@jgbernalp: This pull request explicitly references no jira issue.

Details

In response to this:

This PR:

  • Uses esbuild-loader to speed up prod builds and reduce memory consumption
  • Adds a command to publish the manifest created when building cross platform
  • Increases default nodejs memory for building

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhuje January 2, 2026 11:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2026
@jgbernalp
feat: use esbuild-loader, add push manifest command to makefile
2764d4f 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@etmurasaki
Copy link
Contributor

etmurasaki commented Jan 2, 2026

/test e2e-monitoring

@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 2, 2026

/test ci/prow/okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 2, 2026

@jgbernalp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test images

/test lint

/test okd-scos-images

/test periodics-images

/test translations

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-alerts

/test e2e-aws-ovn-upgrade

/test e2e-coo

/test e2e-dashboards

/test e2e-hypershift-conformance

/test e2e-incidents

/test e2e-metrics

/test e2e-monitoring

/test e2e-monitoring-bvt

/test e2e-monitoring-dev

/test e2e-monitoring-reg

/test e2e-virtualization

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-monitoring-plugin-main-e2e-aws-ovn

pull-ci-openshift-monitoring-plugin-main-e2e-monitoring

pull-ci-openshift-monitoring-plugin-main-images

pull-ci-openshift-monitoring-plugin-main-lint

pull-ci-openshift-monitoring-plugin-main-okd-scos-images

pull-ci-openshift-monitoring-plugin-main-periodics-images

pull-ci-openshift-monitoring-plugin-main-translations

pull-ci-openshift-monitoring-plugin-main-verify-deps
Details

In response to this:

/test ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 2, 2026

/test okd-scos-images

@etmurasaki
Copy link
Contributor

etmurasaki commented Jan 2, 2026

/test e2e-monitoring

1 similar comment
@etmurasaki
Copy link
Contributor

etmurasaki commented Jan 4, 2026

/test e2e-monitoring

@etmurasaki
Copy link
Contributor

etmurasaki commented Jan 5, 2026

/override ci/prow/e2e-monitoring

flaky validation will be removed to not conflict in claimed cluster from pool and cluster provisioned from scratch, impacting in when inline appears.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

@etmurasaki: Overrode contexts on behalf of etmurasaki: ci/prow/e2e-monitoring

Details

In response to this:

/override ci/prow/e2e-monitoring

flaky validation will be removed to not conflict in claimed cluster from pool and cluster provisioned from scratch, impacting in when inline appears.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@etmurasaki
Copy link
Contributor

etmurasaki commented Jan 5, 2026

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 5, 2026
@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 5, 2026

/override ci/prow/okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@PeterYurkovich
Copy link
Contributor

PeterYurkovich commented Jan 5, 2026

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 7ee47f5 into openshift:main Jan 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etmurasaki etmurasaki Awaiting requested review from etmurasaki

@PeterYurkovich PeterYurkovich Awaiting requested review from PeterYurkovich

@zhuje zhuje Awaiting requested review from zhuje

Assignees

@PeterYurkovich PeterYurkovich

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgbernalp @openshift-ci-robot @etmurasaki @PeterYurkovich