Skip to content

OU-1203: upgrade perses dependencies#914

Open
jgbernalp wants to merge 1 commit intoopenshift:mainfrom
jgbernalp:upgrade-perses-dependencies
Open

OU-1203: upgrade perses dependencies#914
jgbernalp wants to merge 1 commit intoopenshift:mainfrom
jgbernalp:upgrade-perses-dependencies

Conversation

@jgbernalp
Copy link
Copy Markdown
Contributor

@jgbernalp jgbernalp commented May 5, 2026

Upgrade perses dependencies to use the prometheus tenancy path

Summary by CodeRabbit

  • Chores
    • Updated UI and plugin packages to newer releases (components, dashboards, explore, plugin system) and adjusted core package version.
    • Pinned console dynamic plugin SDK to a specific prerelease to ensure consistent behavior.
    • Minor internal cleanup in the dashboard editing flow with no user-facing behavior changes.

@jgbernalp jgbernalp requested review from PeterYurkovich and zhuje May 5, 2026 11:47
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 5, 2026

@jgbernalp: This pull request references OU-1203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Upgrade perses dependencies to use the prometheus tenancy path

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2026
@jgbernalp
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-coo-ocp-4.19

@openshift-ci openshift-ci Bot requested a review from etmurasaki May 5, 2026 11:48
@openshift-cherrypick-robot
Copy link
Copy Markdown

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@jgbernalp
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-coo-ocp-4.15

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.15 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8b75707c-1c7c-48ab-8acf-9c2dc4ea2c54

📥 Commits

Reviewing files that changed from the base of the PR and between bc04c2b and 0cf2c0d.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • web/package.json
  • web/src/components/dashboards/perses/dashboard-app.tsx
✅ Files skipped from review due to trivial changes (1)
  • web/src/components/dashboards/perses/dashboard-app.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/package.json

Walkthrough

Updates to dependency versions in web/package.json (Perses packages bumped to 0.54.0-beta.1, @perses-dev/core changed to 0.53.0, and three @openshift-console/dynamic-plugin-sdk* packages pinned to 4.22.0-prerelease.2), plus two small TypeScript cast adjustments in web/src/components/dashboards/perses/dashboard-app.tsx.

Changes

Dependency and minor typing adjustments

Layer / File(s) Summary
Package Manifest
web/package.json
Bump @perses-dev/components, @perses-dev/dashboards, @perses-dev/explore, @perses-dev/plugin-system from 0.53.10.54.0-beta.1. Change @perses-dev/core from 0.53.10.53.0. Pin @openshift-console/dynamic-plugin-sdk, @openshift-console/dynamic-plugin-sdk-internal, @openshift-console/dynamic-plugin-sdk-webpack from ^4.22.0-prerelease.24.22.0-prerelease.2.
Type annotations / UI component
web/src/components/dashboards/perses/dashboard-app.tsx
Simplify casts: handleDiscardChanges now calls onDiscard(dashboard as DashboardResource) (removed double cast); onEditButtonClick sets originalDashboard to dashboard as DashboardResource. No behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading perses dependencies. It is directly related to the primary modifications in the changeset, which involve bumping multiple @perses-dev package versions and updating @openshift-console/dynamic-plugin-sdk dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Custom check for Ginkgo test names is not applicable. PR only modifies TypeScript/JavaScript files (web/package.json and dashboard-app.tsx). No Ginkgo tests or Go test files are modified.
Test Structure And Quality ✅ Passed This PR modifies only TypeScript/JavaScript files and package.json. No Ginkgo tests are present, making the check not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only updates dependencies and makes type cast adjustments. The MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It only updates package.json dependencies and modifies TypeScript React components. The SNO compatibility check is not applicable to this PR.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only frontend web code (npm dependencies and React components), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR changes only TypeScript/JavaScript and package.json files. No Go code modified. Repository uses standard unit tests, not OTE binaries. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It upgrades Perses dependencies and makes type-cast adjustments in TypeScript files. The custom check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/package.json`:
- Around line 76-80: Update the root dependency declaration for
"@perses-dev/core" in package.json from "0.53.1" to "0.53.0" to align with the
peerDependency expected by the `@perses-dev` packages (e.g.
"@perses-dev/components", "@perses-dev/dashboards", "@perses-dev/explore",
"@perses-dev/plugin-system"); locate the "@perses-dev/core" entry in
package.json and change its version string to "0.53.0", then reinstall
dependencies to ensure a single shared copy is used.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4e4161ae-66ec-4368-bc87-c7815f9ca97d

📥 Commits

Reviewing files that changed from the base of the PR and between fe90151 and bc04c2b.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • web/package.json

Comment thread web/package.json
@etmurasaki
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [etmurasaki,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etmurasaki
Copy link
Copy Markdown
Contributor

/retest

2 similar comments
@zhuje
Copy link
Copy Markdown
Contributor

zhuje commented May 5, 2026

/retest

@etmurasaki
Copy link
Copy Markdown
Contributor

/retest

@jgbernalp jgbernalp force-pushed the upgrade-perses-dependencies branch from bc04c2b to 824b10b Compare May 5, 2026 13:17
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2026
@etmurasaki
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2026
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the upgrade-perses-dependencies branch from 824b10b to 0cf2c0d Compare May 5, 2026 17:33
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants