OU-1347: fix: avoid throwing error to fallback to global datasource

[jgbernalp]

Return undefined rather than throwing an error to allow for global or default datasource fallback

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for missing datasources—now returns gracefully instead of throwing an error when the datasource list is unavailable or empty.

[openshift-ci-robot]

@jgbernalp: This pull request references OU-1347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jgbernalp]

/cherry-pick release-coo-ocp-4.22

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0037298c-82cf-4fd3-86eb-3ba185806e43

📥 Commits

Reviewing files that changed from the base of the PR and between 3327aad and 048bd22.

📒 Files selected for processing (1)

• web/src/components/dashboards/perses/datasource-api.ts

---

Walkthrough

The getDatasource method in the Perses datasource API is modified to return undefined instead of throwing an error when the datasource list is empty or non-array.

Changes

Datasource API Error Handling

Layer / File(s)	Summary
Error Handling Logic web/src/components/dashboards/perses/datasource-api.ts	OcpDatasourceApi.getDatasource returns undefined on empty or non-array datasource list instead of throwing an error.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: avoiding throwing an error to allow fallback to global datasource. It is specific and directly related to the primary modification in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-cherrypick-robot]

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jgbernalp]

/cherry-pick release-coo-ocp-4.19

[openshift-cherrypick-robot]

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jgbernalp]

/cherry-pick release-coo-ocp-4.15

[openshift-cherrypick-robot]

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.15 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[PeterYurkovich]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jgbernalp]

/retest ci/prow/okd-scos-images

[jgbernalp]

/test ci/prow/okd-scos-images

[etmurasaki]

/retest

[etmurasaki]

/label qe-approved

[openshift-ci]

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@jgbernalp: new pull request created: #925

Details

In response to this:

/cherry-pick release-coo-ocp-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jgbernalp: new pull request created: #926

Details

In response to this:

/cherry-pick release-coo-ocp-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jgbernalp: new pull request created: #927

Details

In response to this:

/cherry-pick release-coo-ocp-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.