Skip to content

OCPBUGS-79456: immutable bump: fix for CVE-2026-29063 [4.20]#951

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.20from
rhdmalone:release-4.20
May 19, 2026
Merged

OCPBUGS-79456: immutable bump: fix for CVE-2026-29063 [4.20]#951
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.20from
rhdmalone:release-4.20

Conversation

@rhdmalone
Copy link
Copy Markdown
Contributor

Fix CVE-2026-29063 (Prototype Pollution in the immutable npm package) by updating the dependency to patched versions.

Changes:

Bumped immutable in dependencies from 3.x to ^3.8.3 (the minimum patched version for the 3.x range)
Added overrides.sass.immutable: ^5.1.5 to force sass's transitive dependency on immutable to the patched 5.x version
Updated package-lock.json accordingly — both immutable@3.8.3 (direct) and immutable@5.1.5 (scoped under node_modules/sass) are now at their respective patched versions
CVE details:

CVE-2026-29063 — Prototype Pollution via mergeDeep(), mergeDeepWith(), merge(), Map.toJS(), Map.toObject()
Affected: < 3.8.3, >= 4.0.0-rc.1 < 4.3.8, >= 5.0.0-beta.1 < 5.1.5
Fixed: 3.8.3, 4.3.8, 5.1.5

Signed-off-by: Deirdre Malone <dmalone@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-79456, which is invalid:

  • expected Jira Issue OCPBUGS-79456 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fix CVE-2026-29063 (Prototype Pollution in the immutable npm package) by updating the dependency to patched versions.

Changes:

Bumped immutable in dependencies from 3.x to ^3.8.3 (the minimum patched version for the 3.x range)
Added overrides.sass.immutable: ^5.1.5 to force sass's transitive dependency on immutable to the patched 5.x version
Updated package-lock.json accordingly — both immutable@3.8.3 (direct) and immutable@5.1.5 (scoped under node_modules/sass) are now at their respective patched versions
CVE details:

CVE-2026-29063 — Prototype Pollution via mergeDeep(), mergeDeepWith(), merge(), Map.toJS(), Map.toObject()
Affected: < 3.8.3, >= 4.0.0-rc.1 < 4.3.8, >= 5.0.0-beta.1 < 5.1.5
Fixed: 3.8.3, 4.3.8, 5.1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 85cd822a-5aa2-4138-b8f6-b4c6fcdb6aef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from PeterYurkovich and zhuje May 18, 2026 14:34
@rhdmalone
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-79456, which is invalid:

  • expected dependent Jira Issue OCPBUGS-79460 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Copy Markdown
Contributor

/lgtm

@jgbernalp
Copy link
Copy Markdown
Contributor

/test e2e-monitoring

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, rhdmalone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@rhdmalone
Copy link
Copy Markdown
Contributor Author

/test e2e-monitoring

@rhdmalone
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-79456, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-79460 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-79460 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhdmalone
Copy link
Copy Markdown
Contributor Author

rhdmalone commented May 19, 2026

Comments from Claude on e2e-monitoring failure on Tuesday May 19th
https://storage.googleapis.com/test-platform-results/pr-logs/pull/openshift_monitoring-plugin/951/pull-ci-openshift-monitoring-plugin-release-4.20-e2e-monitoring/2056666308753231872/build-log.txt

Comment 1:
"Now I can see the exact sequence. The test fails at line 56:

cy.byTestID(DataTestIDs.MetricGraphNoDatapointsFound).eq(0).scrollIntoView().should('be.visible');
The test:

Clicks the K8S_COMPUTE_RESOURCES_POD dashboard dropdown (line 55)
Then expects a [data-test="datapoints-msg"] "no datapoints" empty state element to appear (line 56)
The assumption is that the K8S_COMPUTE_RESOURCES_POD dashboard will have no data (showing the empty state), but in the CI environment it apparently does have data — so the datapoints-msg empty state element never renders.

This is a pre-existing flaky test — it relies on a specific dashboard having no datapoints in the CI cluster environment, which isn't guaranteed. It's nothing to do with your CVE changes."

Comment 2:

"There aren't actually 2 separate Cypress test failures — there is only 1 Cypress test failure (the datapoints-msg one). The 2 failing CI steps reported are:

e2e-monitoring-monitoring-plugin-tests-monitoring-ui — the container running the Cypress tests. It failed with exit code 1 because 1 Cypress test failed inside it.

Step phase test — this is the parent CI pipeline step that wraps the test container. It failed because step 1 failed — it's a cascading failure, not an independent one.

So in summary: one root cause (the datapoints-msg Cypress assertion in 03.reg_legacy_dashboards_admin.cy.ts), which causes two CI steps to be reported as failed. The second step failure is just the pipeline propagating the exit code upward."

@rhdmalone
Copy link
Copy Markdown
Contributor Author

/test e2e-monitoring

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@rhdmalone: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-monitoring 7e569b1 link false /test e2e-monitoring

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@etmurasaki
Copy link
Copy Markdown
Contributor

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 19, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 8e62a3b into openshift:release-4.20 May 19, 2026
7 of 8 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@rhdmalone: Jira Issue OCPBUGS-79456: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-79456 has been moved to the MODIFIED state.

Details

In response to this:

Fix CVE-2026-29063 (Prototype Pollution in the immutable npm package) by updating the dependency to patched versions.

Changes:

Bumped immutable in dependencies from 3.x to ^3.8.3 (the minimum patched version for the 3.x range)
Added overrides.sass.immutable: ^5.1.5 to force sass's transitive dependency on immutable to the patched 5.x version
Updated package-lock.json accordingly — both immutable@3.8.3 (direct) and immutable@5.1.5 (scoped under node_modules/sass) are now at their respective patched versions
CVE details:

CVE-2026-29063 — Prototype Pollution via mergeDeep(), mergeDeepWith(), merge(), Map.toJS(), Map.toObject()
Affected: < 3.8.3, >= 4.0.0-rc.1 < 4.3.8, >= 5.0.0-beta.1 < 5.1.5
Fixed: 3.8.3, 4.3.8, 5.1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants