OCPBUGS-79456: immutable bump: fix for CVE-2026-29063 [4.20]#951
Conversation
Signed-off-by: Deirdre Malone <dmalone@redhat.com>
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-79456, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira refresh |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-79456, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/test e2e-monitoring |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, rhdmalone The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-monitoring |
|
/jira refresh |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-79456, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Comments from Claude on e2e-monitoring failure on Tuesday May 19th Comment 1: cy.byTestID(DataTestIDs.MetricGraphNoDatapointsFound).eq(0).scrollIntoView().should('be.visible'); Clicks the K8S_COMPUTE_RESOURCES_POD dashboard dropdown (line 55) This is a pre-existing flaky test — it relies on a specific dashboard having no datapoints in the CI cluster environment, which isn't guaranteed. It's nothing to do with your CVE changes." Comment 2: "There aren't actually 2 separate Cypress test failures — there is only 1 Cypress test failure (the datapoints-msg one). The 2 failing CI steps reported are: e2e-monitoring-monitoring-plugin-tests-monitoring-ui — the container running the Cypress tests. It failed with exit code 1 because 1 Cypress test failed inside it. Step phase test — this is the parent CI pipeline step that wraps the test container. It failed because step 1 failed — it's a cascading failure, not an independent one. So in summary: one root cause (the datapoints-msg Cypress assertion in 03.reg_legacy_dashboards_admin.cy.ts), which causes two CI steps to be reported as failed. The second step failure is just the pipeline propagating the exit code upward." |
|
/test e2e-monitoring |
|
@rhdmalone: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
8e62a3b
into
openshift:release-4.20
|
@rhdmalone: Jira Issue OCPBUGS-79456: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-79456 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fix CVE-2026-29063 (Prototype Pollution in the immutable npm package) by updating the dependency to patched versions.
Changes:
Bumped immutable in dependencies from 3.x to ^3.8.3 (the minimum patched version for the 3.x range)
Added overrides.sass.immutable: ^5.1.5 to force sass's transitive dependency on immutable to the patched 5.x version
Updated package-lock.json accordingly — both immutable@3.8.3 (direct) and immutable@5.1.5 (scoped under node_modules/sass) are now at their respective patched versions
CVE details:
CVE-2026-29063 — Prototype Pollution via mergeDeep(), mergeDeepWith(), merge(), Map.toJS(), Map.toObject()
Affected: < 3.8.3, >= 4.0.0-rc.1 < 4.3.8, >= 5.0.0-beta.1 < 5.1.5
Fixed: 3.8.3, 4.3.8, 5.1.5