CNF-21001: Remove iptables compatibility commits

[zeeke]

Since

• CNF-21001: multus: MultiNetworkPolicy nftables cluster-network-operator#2883

has been merged, we can remove the compatibility with the old iptables implementation

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 463344a6-8cf4-4c75-b2fd-695b2330bd40

📥 Commits

Reviewing files that changed from the base of the PR and between 834a093 and 984b663.

📒 Files selected for processing (2)

• Dockerfile.openshift
• cmd/main.go

💤 Files with no reviewable changes (2)

• Dockerfile.openshift
• cmd/main.go

---

Walkthrough

The pull request removes iptables compatibility code throughout the project. Specifically, it eliminates a Dockerfile symlink that provided backward compatibility for iptables-based execution and removes the --pod-iptables CLI flag from the main command, along with associated logic that reset and configured IPv6 rule defaults.

Changes

Cohort / File(s)	Summary
Remove iptables compatibility layer Dockerfile.openshift, cmd/main.go	Removed symlink creation for iptables binary alias, eliminated --pod-iptables CLI flag, and removed logic that reset commonRules and set hardcoded IPv6 ICMPv6 discovery rules. Code now uses nftables exclusively without backward compatibility for iptables mode.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@zeeke: This pull request references CNF-21001 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Since

• CNF-21001: multus: MultiNetworkPolicy nftables cluster-network-operator#2883

has been merged, we can remove the compatibility with the old iptables implementation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cgoncalves]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [zeeke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zeeke]

/verified by CI
ci/prow/e2e-aws

[openshift-ci-robot]

@zeeke: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI
ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.