[Release-4.19] OCPBUGS-67251,OCPBUGS-66279: fix node-forge by upgrading webpack-dev-server: ^4.7.4 → ^5.2.3" by MrSanketkumar · Pull Request #410 · openshift/networking-console-plugin

MrSanketkumar · 2026-05-04T10:45:39Z

Summary by CodeRabbit

Chores
- Updated development tooling dependencies for improved build performance and compatibility.

…server: ^4.7.4 → ^5.2.3

coderabbitai · 2026-05-04T10:45:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3b5b3d88-218c-4940-ac9d-568adc8f65a3

📥 Commits

Reviewing files that changed from the base of the PR and between 9893901 and ddf05d7.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

package.json

Walkthrough

The webpack-dev-server development dependency is updated from version ^4.7.4 to ^5.2.3, introducing a major version bump across the build tooling stack.

Changes

Dependency Update

Layer / File(s)	Summary
Development Dependencies `package.json`	`webpack-dev-server` bumped from `^4.7.4` to `^5.2.3`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: upgrading webpack-dev-server from version ^4.7.4 to ^5.2.3 to address security issues, which matches the actual changeset modification in package.json.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The custom check for Ginkgo test name stability is not applicable to this JavaScript/TypeScript project that uses Cypress, not Go/Ginkgo.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test structure is not applicable to this JavaScript/TypeScript project using Cypress for testing.
Microshift Test Compatibility	✅ Passed	PR only updates webpack-dev-server dependency; no Ginkgo e2e tests added, making the check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR updates webpack-dev-server in a TypeScript/Node.js console plugin project with no Ginkgo e2e tests, making the SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates webpack-dev-server dependency version; no deployment manifests, operator code, or controllers modified.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable to this PR. It targets Go-based test projects using Ginkgo framework with OTE infrastructure, but this PR modifies a TypeScript/JavaScript project and only updates webpack-dev-server dependency.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies package.json (webpack-dev-server dependency version bump) and does not add any new Ginkgo e2e tests, making this check inapplicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-05-04T10:45:49Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-67251, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-67251 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-66279, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-66279 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MrSanketkumar · 2026-05-04T10:46:32Z

@coderabbitai review

coderabbitai · 2026-05-04T10:46:38Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

openshift-ci-robot · 2026-05-04T10:47:15Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-67251, which is invalid:

expected Jira Issue OCPBUGS-67251 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-66279, which is invalid:

expected Jira Issue OCPBUGS-66279 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Summary by CodeRabbit

Chores

Updated development tooling dependencies for improved build performance and compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MrSanketkumar · 2026-05-04T10:54:11Z

/jira refresh

openshift-ci-robot · 2026-05-04T10:54:17Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-67251, which is invalid:

expected dependent Jira Issue OCPBUGS-67252 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-66279, which is invalid:

expected dependent Jira Issue OCPBUGS-66283 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MrSanketkumar · 2026-05-04T11:12:37Z

/jira refresh

openshift-ci-robot · 2026-05-04T11:12:46Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-67251, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-67252 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-67252 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

This pull request references Jira Issue OCPBUGS-66279, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-66283 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-66283 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-04T12:11:03Z

@MrSanketkumar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pcbailey · 2026-05-04T12:52:26Z

/lgtm

upalatucci · 2026-05-04T12:57:41Z

/approve

openshift-ci · 2026-05-04T12:57:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrSanketkumar, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-05-04T13:02:19Z

@MrSanketkumar: An error was encountered invalid pull identifier with 2 parts: "digitalbazaar/forge" for bug OCPBUGS-67251 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message.

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.Jira Issue OCPBUGS-67251: All pull requests linked via external trackers have merged:

openshift/networking-console-plugin#410

Jira Issue OCPBUGS-67251 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-66279: All pull requests linked via external trackers have merged:

openshift/networking-console-plugin#410

Jira Issue OCPBUGS-66279 has been moved to the MODIFIED state.

Details

In response to this:

Summary by CodeRabbit

Chores

Updated development tooling dependencies for improved build performance and compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-05-05T01:03:12Z

Fix included in release 4.19.0-0.nightly-2026-05-04-214040

OCPBUGS-67251,OCPBUGS-66279: fix node-forge by upgrading webpack-dev-…

ddf05d7

…server: ^4.7.4 → ^5.2.3

openshift-ci Bot requested review from adamviktora and upalatucci May 4, 2026 10:45

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 4, 2026

openshift-ci Bot assigned pcbailey May 4, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026

openshift-merge-bot Bot merged commit c754eed into openshift:release-4.19 May 4, 2026
5 checks passed

Conversation

MrSanketkumar commented May 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci-robot commented May 4, 2026

Uh oh!

MrSanketkumar commented May 4, 2026

Uh oh!

coderabbitai Bot commented May 4, 2026

Uh oh!

openshift-ci-robot commented May 4, 2026

Summary by CodeRabbit

Uh oh!

MrSanketkumar commented May 4, 2026

Uh oh!

openshift-ci-robot commented May 4, 2026

Uh oh!

MrSanketkumar commented May 4, 2026

Uh oh!

openshift-ci-robot commented May 4, 2026

Uh oh!

openshift-ci Bot commented May 4, 2026

Uh oh!

pcbailey commented May 4, 2026

Uh oh!

upalatucci commented May 4, 2026

Uh oh!

openshift-ci Bot commented May 4, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 4, 2026

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MrSanketkumar commented May 4, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 4, 2026 •

edited

Loading