Skip to content

Conversation

@aviavissar
Copy link

@aviavissar aviavissar commented Jan 26, 2026

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

  1. fix resize form
  2. the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:

Video_2026-01-26_11-42-45.mp4

after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
@openshift-ci openshift-ci bot requested review from metalice and tnisan January 26, 2026 09:35
@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aviavissar
Once this PR has been reviewed and has the lgtm label, please assign metalice for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 26, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

Hi @aviavissar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

#jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

##jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

  1. fix resize form
  2. the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

  1. fix resize form
  2. the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:

Video_2026-01-26_11-42-45.mp4

after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aviavissar aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 8ce5fd0 to 895a588 Compare January 26, 2026 10:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
Copy link

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design leaves the title bar visible with the wizard appearing before it. Can you place the drawer beneath the title bar?

Design doc: https://docs.google.com/document/d/1_CB2VknL427uZrbswV113CIfCGZa8OtvVyDkZUgsO54/edit?tab=t.0#heading=h.t0q1cztjdow9

children: React.ReactNode;
};

const TopologyDrawer: React.FC<Props> = ({ isOpen, onClose, panel, children }) => (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import FC and remove React..

@@ -1,5 +1,5 @@
.pf-v6-c-toolbar__group.pf-topology-view__view-toolbar {
width: 100%;
width: 100%;padding-left: 200px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place padding-left: 200px on the next line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants