OCPBUGS-77766: OCPBUGS-77765: NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile by openshift-cherrypick-robot · Pull Request #168 · openshift/node-feature-discovery

openshift-cherrypick-robot · 2026-03-03T21:32:54Z

This is an automated cherry-pick of #163

/assign lgarciaaco

Hermetic (Cachito/cachi2) builds override GOBIN, so go install places binaries in a different location than /go/bin, causing COPY --from=builder /go/bin/* /usr/bin/ to fail. Fix is to replace make install (which uses go install) with make build (which uses go build) and explicitly output binaries to /go/node-feature-discovery/bin, then copy from that deterministic path into /usr/bin/.

openshift-ci · 2026-03-03T21:42:29Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yevgeny-shnaidman · 2026-03-04T08:33:28Z

/approve

openshift-ci · 2026-03-04T08:33:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yevgeny-shnaidman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yevgeny-shnaidman · 2026-03-04T08:34:35Z

/lgtm

yevgeny-shnaidman · 2026-03-04T08:34:42Z

/verified bypass

openshift-ci-robot · 2026-03-04T08:34:55Z

@yevgeny-shnaidman: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yevgeny-shnaidman · 2026-03-04T08:35:13Z

/label backport-risk-assessed

lgarciaaco · 2026-03-04T08:52:55Z

/hold for testing

lgarciaaco · 2026-03-04T09:26:46Z

/unhold
test references openshift-eng/ocp-build-data#9221

lgarciaaco · 2026-03-04T09:37:38Z

/retitle NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile

lgarciaaco · 2026-03-04T09:41:53Z

/label jira/valid-bug

openshift-ci · 2026-03-04T09:43:32Z

@lgarciaaco: The label(s) jira/valid-bug cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-staff-engineers, openshift-release-oversight, openshift-sustaining-engineers

Details

In response to this:

/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lgarciaaco · 2026-03-04T10:02:18Z

/jira cherrypick OCPBUGS-77763

openshift-ci-robot · 2026-03-04T10:02:31Z

@lgarciaaco: Jira Issue OCPBUGS-77763 has been cloned as Jira Issue OCPBUGS-77765. Will retitle bug to link to clone.
/retitle OCPBUGS-77765: NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile

Details

In response to this:

/jira cherrypick OCPBUGS-77763

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-04T10:02:46Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-77765, which is invalid:

expected dependent Jira Issue OCPBUGS-77763 to target a version in 4.20.0, 4.20.z, but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #163

/assign lgarciaaco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lgarciaaco · 2026-03-04T10:07:12Z

/jira refresh

openshift-ci-robot · 2026-03-04T10:07:18Z

@lgarciaaco: This pull request references Jira Issue OCPBUGS-77765, which is invalid:

expected dependent Jira Issue OCPBUGS-77763 to target a version in 4.20.0, 4.20.z, but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lgarciaaco · 2026-03-04T10:11:10Z

/jira refresh

openshift-ci-robot · 2026-03-04T10:11:16Z

@lgarciaaco: This pull request references Jira Issue OCPBUGS-77765, which is invalid:

expected dependent Jira Issue OCPBUGS-77763 to target a version in 4.20.0, 4.20.z, but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lgarciaaco · 2026-03-04T10:12:05Z

/jira cherrypick OCPBUGS-77764

openshift-ci-robot · 2026-03-04T10:12:18Z

@lgarciaaco: Jira Issue OCPBUGS-77764 has been cloned as Jira Issue OCPBUGS-77766. Will retitle bug to link to clone.
/retitle OCPBUGS-77766: OCPBUGS-77765: NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile

Details

In response to this:

/jira cherrypick OCPBUGS-77764

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-04T10:12:25Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-77766, which is invalid:

expected dependent Jira Issue OCPBUGS-77764 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #163

/assign lgarciaaco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lgarciaaco · 2026-03-04T10:13:38Z

/jira refresh

openshift-ci-robot · 2026-03-04T10:13:49Z

@lgarciaaco: This pull request references Jira Issue OCPBUGS-77766, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-77764 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-77764 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ggordani@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-04T10:18:59Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-77766: All pull requests linked via external trackers have merged:

openshift/node-feature-discovery#168

All linked pull requests have the verified tag. Jira Issue OCPBUGS-77766 has been moved to the VERIFIED state.

Details

In response to this:

This is an automated cherry-pick of #163

/assign lgarciaaco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot assigned lgarciaaco Mar 3, 2026

openshift-cherrypick-robot mentioned this pull request Mar 3, 2026

NO-JIRA: fix hermetic build binary path issue in dockerfile #163

Merged

openshift-ci bot requested review from TomerNewman and yevgeny-shnaidman March 3, 2026 21:33

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026

openshift-ci bot assigned yevgeny-shnaidman Mar 4, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 4, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 4, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026

openshift-ci bot changed the title ~~[release-4.19] NO-JIRA: fix hermetic build binary path issue in dockerfile~~ NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile Mar 4, 2026

openshift-ci bot changed the title ~~NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile~~ OCPBUGS-77765: NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile Mar 4, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2026

openshift-ci bot changed the title ~~OCPBUGS-77765: NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile~~ OCPBUGS-77766: OCPBUGS-77765: NO-JIRA: [release-4.19] fix hermetic build binary path issue in dockerfile Mar 4, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2026

openshift-merge-bot bot merged commit e21805d into openshift:release-4.19 Mar 4, 2026
5 checks passed

Conversation

openshift-cherrypick-robot commented Mar 3, 2026

Uh oh!

openshift-ci bot commented Mar 3, 2026

Uh oh!

yevgeny-shnaidman commented Mar 4, 2026

Uh oh!

openshift-ci bot commented Mar 4, 2026

Uh oh!

yevgeny-shnaidman commented Mar 4, 2026

Uh oh!

yevgeny-shnaidman commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

yevgeny-shnaidman commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

openshift-ci bot commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

lgarciaaco commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants