OCPBUGS-62727: Bump openshift/node_exporter to v1.10.2 #172

simonpasquier · 2025-10-28T09:40:37Z

No description provided.

* Remove obsolete buildkite badge. * Add GitHub actions workflow badges. Signed-off-by: Ben Kochie <superq@gmail.com>

Remove formatting that doesn't render properly. Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>

Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>

* feat: add SystemdVirtualization type --------- Signed-off-by: IbraAoad <Ibrahim.Awwad@canonical.com> Signed-off-by: Ibrahim Awwad <ibraaoad@gmail.com> Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info> Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com> Co-authored-by: Mikel Olasagasti Uranga <mikel@olasagasti.info> Co-authored-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>

Use `sysfs` for RAID stats. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

* Update Go to 1.24 for all builds. * Update minimum Go version to 1.23. * Bump procfs library. Signed-off-by: Ben Kochie <superq@gmail.com>

) Signed-off-by: Rolf Klemenz <tickez@madnet.ch>

Fix S1009: should omit nil check; len() for nil maps is defined as zero (gosimple) Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: prombot <prometheus-team@googlegroups.com> Co-authored-by: Ben Kochie <superq@gmail.com>

Signed-off-by: prombot <prometheus-team@googlegroups.com>

Ignore `node_cpu_frequency_max_hertz` to fix flaky Solaris end-to-end test. Signed-off-by: Ben Kochie <superq@gmail.com>

Sanitize zero terminated strings from OpenBSD device name parsing. * Add byte-to-string util function. Fixes: prometheus#3287 Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: prombot <prometheus-team@googlegroups.com>

Use `utils.SafeBytesToString()` to sanitize C strings the Darwin thermal collector. Signed-off-by: Ben Kochie <superq@gmail.com>

As the comment says, this can be simplified now. Signed-off-by: Manuel Rüger <manuel@rueg.eu>

…1.21.0 (prometheus#3262) * build(deps): bump github.com/prometheus/client_golang Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.5 to 1.21.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.5...v1.21.0) Signed-off-by: Ben Kochie <superq@gmail.com> --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update e2e fixtures for new client_golang. Signed-off-by: Ben Kochie <superq@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com>

…3266) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.36.0. - [Commits](golang/net@v0.33.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fix "no data" error on kernels that support some PSI status, but don't yet have IRQ presure metrics. Only report "no data" error if `pressure` is enabled and no PSI metrics were found. Fixes: prometheus#3259 Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

There is a bug in darwin kernel since macOS Ventura 13.2.1, which results in interface i/o bytes values to be truncated at 4GiB. This change uses a workaround to collect the same metrics, taking advantage of another bug. fixes prometheus#3333 Signed-off-by: Siavash Safi <git@hosted.run>

…theus#3323) Bumps [github.com/mdlayher/wifi](https://github.com/mdlayher/wifi) from 0.3.1 to 0.5.0. - [Release notes](https://github.com/mdlayher/wifi/releases) - [Commits](mdlayher/wifi@v0.3.1...v0.5.0) --- updated-dependencies: - dependency-name: github.com/mdlayher/wifi dependency-version: 0.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

The ethtool_linux looks for ethtool stats with their sanitized name which might be different from the name provisioned by ethtool. This caused node-exporter to return a 0-value for sanitized metrics. This patch works-around the missing key by copying ethtool stats to another map under their sanitized name. Signed-off-by: Guillaume Espanel <guillaume.espanel@ovhcloud.com> Co-authored-by: Guillaume Espanel <guillaume.espanel@ovhcloud.com>

…3324) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.30.0 to 0.32.0. - [Commits](golang/sys@v0.30.0...v0.32.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.32.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Nabil <nabilcharaf37@gmail.com>

Signed-off-by: Johannes Ziemke <github@5pi.de>

openshift-ci-robot · 2025-10-28T09:40:43Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-62727, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2025-10-28T09:41:45Z

/jira refresh

openshift-ci-robot · 2025-10-28T09:41:59Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-62727, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2025-10-28T09:49:23Z

/jira backport release-4.20

openshift-ci-robot · 2025-10-28T09:49:35Z

@simonpasquier: The following backport issues have been created:

OCPBUGS-63624 for branch release-4.20

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20

In response to this:

/jira backport release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-10-28T09:49:38Z

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

In response to this:

@simonpasquier: The following backport issues have been created:

OCPBUGS-63624 for branch release-4.20

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20

In response to this:

/jira backport release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

openshift-ci · 2025-10-28T15:54:32Z

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

juzhao · 2025-10-31T06:10:56Z

/verified by @juzhao

openshift-ci-robot · 2025-10-31T06:11:08Z

@juzhao: This PR has been marked as verified by @juzhao.

In response to this:

/verified by @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

danielmellado · 2025-10-31T15:08:05Z

/lgtm

openshift-ci · 2025-10-31T15:09:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danielmellado,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-10-31T15:11:50Z

@simonpasquier: Jira Issue Verification Checks: Jira Issue OCPBUGS-62727
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62727 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-10-31T15:12:34Z

@openshift-ci-robot: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error message

status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

In response to this:

@simonpasquier: The following backport issues have been created:

OCPBUGS-63624 for branch release-4.20

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20

In response to this:

/jira backport release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-11-04T03:57:16Z

Fix included in accepted release 4.21.0-0.nightly-2025-11-03-191704

SuperQ and others added 30 commits February 17, 2025 12:07

Update status badges

d611fb2

* Remove obsolete buildkite badge. * Add GitHub actions workflow badges. Signed-off-by: Ben Kochie <superq@gmail.com>

Fixup README formatting (prometheus#3251)

8107c3f

Remove formatting that doesn't render properly. Signed-off-by: Ben Kochie <superq@gmail.com>

build(deps): remove leftover from prometheus#3160 (prometheus#3255)

7c69600

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>

bugfix: 🐛 remove invalid variable from cluster use dashboards

ae746c8

Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>

collector/mdadm: Support RAID metrics (prometheus#3031)

0c10545

Use `sysfs` for RAID stats. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Update Go to 1.24 (prometheus#3273)

5d45895

* Update Go to 1.24 for all builds. * Update minimum Go version to 1.23. * Bump procfs library. Signed-off-by: Ben Kochie <superq@gmail.com>

Avoid memory leak by using value rather than reference. (prometheus#3277

47e2bb3

) Signed-off-by: Rolf Klemenz <tickez@madnet.ch>

Fix linter warning (prometheus#3280)

58ac08e

Fix S1009: should omit nil check; len() for nil maps is defined as zero (gosimple) Signed-off-by: Ben Kochie <superq@gmail.com>

Update common Prometheus files (prometheus#3264)

9b898b8

Signed-off-by: prombot <prometheus-team@googlegroups.com> Co-authored-by: Ben Kochie <superq@gmail.com>

Update common Prometheus files (prometheus#3286)

93b79b4

Signed-off-by: prombot <prometheus-team@googlegroups.com>

Fix flaky Solaris test (prometheus#3289)

e768aad

Ignore `node_cpu_frequency_max_hertz` to fix flaky Solaris end-to-end test. Signed-off-by: Ben Kochie <superq@gmail.com>

Fix OpenBSD interrupt device parsing (prometheus#3288)

729a031

Sanitize zero terminated strings from OpenBSD device name parsing. * Add byte-to-string util function. Fixes: prometheus#3287 Signed-off-by: Ben Kochie <superq@gmail.com>

Update common Prometheus files (prometheus#3291)

8c3f1a2

Signed-off-by: prombot <prometheus-team@googlegroups.com>

Sanitize darwin thermal strings (prometheus#3294)

e5caa39

Use `utils.SafeBytesToString()` to sanitize C strings the Darwin thermal collector. Signed-off-by: Ben Kochie <superq@gmail.com>

diskstats: Simplify condition (prometheus#3290)

8804ce1

As the comment says, this can be simplified now. Signed-off-by: Manuel Rüger <manuel@rueg.eu>

Fix macos filesystem collector cgo memory leak (prometheus#3315)

43fb05c

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

chore: fix some typos (prometheus#3316)

e942bae

Signed-off-by: Nabil <nabilcharaf37@gmail.com>

AIX: Add physical cpu, runqueue and flag metrics

853af0c

Signed-off-by: Johannes Ziemke <github@5pi.de>

AIX: Add more disk metrics

2c33bc5

Signed-off-by: Johannes Ziemke <github@5pi.de>

AIX: Add paging memory metrics

65d2538

Signed-off-by: Johannes Ziemke <github@5pi.de>

AIX: Add transmit_queue_overflow metric to netdev collector

481b824

Signed-off-by: Johannes Ziemke <github@5pi.de>

AIX: Add netadapter collision counters

430023e

Signed-off-by: Johannes Ziemke <github@5pi.de>

simonpasquier mentioned this pull request Oct 28, 2025

[bot] Bump openshift/node_exporter to v1.10.0 #171

Merged

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 28, 2025

openshift-ci bot requested a review from machine424 October 28, 2025 09:41

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 28, 2025

openshift-ci bot requested review from juzhao and slashpai October 28, 2025 09:41

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025

Separate accelerators fixture from upstream fixtures

90e1051

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

simonpasquier force-pushed the pr/171 branch from ed2242b to 90e1051 Compare October 28, 2025 10:19

simonpasquier added 2 commits October 28, 2025 12:01

Fix unit tests for the accelerators collector

4c1930a

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

Change PCI device id to avoid .gitignore clash

ceb0b49

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 31, 2025

openshift-ci bot assigned danielmellado Oct 31, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025

openshift-merge-bot bot merged commit 39d7287 into openshift:main Oct 31, 2025
11 checks passed

simonpasquier deleted the pr/171 branch October 31, 2025 15:27

OCPBUGS-62727: Bump openshift/node_exporter to v1.10.2 #172

OCPBUGS-62727: Bump openshift/node_exporter to v1.10.2 #172

Uh oh!

Conversation

simonpasquier commented Oct 28, 2025

Uh oh!

openshift-ci-robot commented Oct 28, 2025

Uh oh!

simonpasquier commented Oct 28, 2025

Uh oh!

openshift-ci-robot commented Oct 28, 2025

Uh oh!

simonpasquier commented Oct 28, 2025

Uh oh!

openshift-ci-robot commented Oct 28, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 28, 2025

Uh oh!

openshift-ci bot commented Oct 28, 2025

Uh oh!

juzhao commented Oct 31, 2025

Uh oh!

openshift-ci-robot commented Oct 31, 2025

Uh oh!

danielmellado commented Oct 31, 2025

Uh oh!

openshift-ci bot commented Oct 31, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 31, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 31, 2025

Uh oh!

openshift-merge-robot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

36 participants