Add different cloud provider support between BSL and VSL#124
Closed
shubham-pampattiwar wants to merge 5 commits intoopenshift:masterfrom
Closed
Add different cloud provider support between BSL and VSL#124shubham-pampattiwar wants to merge 5 commits intoopenshift:masterfrom
shubham-pampattiwar wants to merge 5 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
shubham-pampattiwar
force-pushed
the
add-diff-bsl-vsl-support
branch
from
8f3c94b to
590970d
Compare
openshift-ci
bot
removed
the
needs-rebase
shubham-pampattiwar
changed the title
dymurray
reviewed
Jul 7, 2021
Member
dymurray
left a comment
dymurray
left a comment
There was a problem hiding this comment.
This looks good. Just need to test it on my end. I would like to merge this before cutting a new release
dymurray
reviewed
Jul 9, 2021
dymurray
reviewed
Jul 9, 2021
dymurray
reviewed
Jul 9, 2021
dymurray
reviewed
Jul 9, 2021
Member
dymurray
left a comment
dymurray
left a comment
There was a problem hiding this comment.
overall the functionality LGTM and it ran in my env fine.
I have some questions about the ansible logic that I think is just my peeve of doing this in ansible (and we did this before so I'm probably overthinking it).
I'm fine to merge this but if you want to wait until next week I'd be interested in talking through some ideas I have on changing this slightly.
Contributor
|
/retest |
openshift-ci
bot
added
the
needs-rebase
shubham-pampattiwar
force-pushed
the
add-diff-bsl-vsl-support
branch
from
5ab592f to
e556917
Compare
openshift-ci
bot
removed
the
needs-rebase
|
@shubham-pampattiwar: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
…1937) * Exponential Backoff for CloudStorage reconciler - Add Conditions field to CloudStorageStatus for better observability - Implement exponential backoff by returning errors on bucket operations - Controller-runtime automatically handles retries (5ms to 1000s max) - Add condition constants for type-safe reason strings - Create mock bucket client for improved testing - Add comprehensive tests for backoff behavior and conditions Key improvements: - Standard Kubernetes pattern using built-in workqueue backoff - Self-healing: continues retrying with increasing delays - Better observability through status conditions - Per-item backoff: each CloudStorage CR gets independent retry timing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add exponential backoff for CloudStorage status update failures (#124) * Initial plan * Add exponential backoff for status update failures - Return error instead of just logging when final status update fails - Add documentation test explaining the change - Ensures controller-runtime's exponential backoff is triggered for status update failures Addresses PR comment #1937 discussion_r2330918689 Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/oadp-operator
that referenced
this pull request
Sep 9, 2025
…shift#124) * Initial plan * Add exponential backoff for status update failures - Return error instead of just logging when final status update fails - Add documentation test explaining the change - Ensures controller-runtime's exponential backoff is triggered for status update failures Addresses PR comment openshift#1937 discussion_r2330918689 Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
…queueAfter (#1951) * Exponential Backoff for CloudStorage reconciler - Add Conditions field to CloudStorageStatus for better observability - Implement exponential backoff by returning errors on bucket operations - Controller-runtime automatically handles retries (5ms to 1000s max) - Add condition constants for type-safe reason strings - Create mock bucket client for improved testing - Add comprehensive tests for backoff behavior and conditions Key improvements: - Standard Kubernetes pattern using built-in workqueue backoff - Self-healing: continues retrying with increasing delays - Better observability through status conditions - Per-item backoff: each CloudStorage CR gets independent retry timing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add exponential backoff for CloudStorage status update failures (#124) * Initial plan * Add exponential backoff for status update failures - Return error instead of just logging when final status update fails - Add documentation test explaining the change - Ensures controller-runtime's exponential backoff is triggered for status update failures Addresses PR comment #1937 discussion_r2330918689 Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com> --------- Co-authored-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Changes tested for: