public velero ref 1.18.1 to match openshift/velero replace

[msfrucht]

Why the changes were made

The replace is pointing to the Openshift fork of Velero 1.18.1 but the advertised dependency is Velero 1.14.

This causes all downstream use to need a replace statement to use the appropriate api versions.

How to test the changes made

Changes only to go.mod and there is a replace in go.mod. Code and unit tests should be unaffected. Build should be enough test this along with using the branch as a go import.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d5d4119d-8023-436a-b9cd-920c0f7231c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hi @msfrucht. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kaovilai]

/ok-to-test
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, msfrucht, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shubham-pampattiwar]

Quick question: did you run go mod tidy after making this change? Since the replace directive means Go never actually fetches vmware-tanzu/velero@v1.18.1, the go.sum wouldn't change, but just want to confirm tidy was run to validate everything resolves cleanly.

[kaovilai]

@shubham-pampattiwar all good.

@kaovilai ➜ /workspaces/oadp-operator (fix_downstream_pulling_older_velero) $ git rev-parse --short HEAD
7fdd25d
@kaovilai ➜ /workspaces/oadp-operator (fix_downstream_pulling_older_velero) $ go mod tidy && git status             
On branch fix_downstream_pulling_older_velero
Your branch is up to date with 'origin/fix_downstream_pulling_older_velero'.

nothing to commit, working tree clean

[kaovilai]

I'm pretty sure otherwise the unit test would have failed.

[openshift-ci]

@msfrucht: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[msfrucht]

@shubham-pampattiwar Of course I did.

I wasn't surprised there was no change because of the openshift/velero replace.

[weshayutin]

/cherry-pick oadp-dev

[openshift-cherrypick-robot]

@weshayutin: new pull request created: #2229

Details

In response to this:

/cherry-pick oadp-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.