OCPBUGS-64657: external/openid: Unwrap groups encoded as string

[tchap]

Unwrap groups array claim when encoded as a simple string.
This means decoding "groups": "[\"A\", \"B\"]" into ["A", "B"]
groups claim value.

I also made the array parsing more strict, failing on unexpected type encountered instead of ignore/panic.

Let me know if we need to add more tests somewhere.

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-64657, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Unwrap groups array claim when encoded as a simple string.
This means decoding "groups": "[\"A\", \"B\"]" into ["A", "B"]
groups claim value.

I also made the array parsing more strict, failing on unexpected type encountered instead of ignore/panic.

Let me know if we need to add more tests somewhere.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/jira refresh

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-64657, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign ibihim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ibihim]

/hold

This is a regression and has potential to backfire massively with parsing discrepancies.
There must be some more research what is going on.

In its current state, It could pass as a feature request hidden behind a config.