Skip to content

NO-JIRA: Revert adm release new: simplify writePayload" #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

NO-JIRA: Revert adm release new: simplify writePayload" #2000

merged 1 commit into from
Mar 28, 2025

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Mar 28, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 28, 2025

@petr-muller: This pull request explicitly references no jira issue.

In response to this:

Reverts #1997

https://redhat-internal.slack.com/archives/C06Q309QUDV/p1743183670944419

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ardaguclu and atiratree March 28, 2025 18:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@jupierce
Copy link
Contributor

jupierce commented Mar 28, 2025

Force merge on @petr-muller's request to eliminate possible fallout in release controller.

@jupierce jupierce merged commit 314ad39 into openshift:master Mar 28, 2025
2 of 14 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli
This PR has been included in build openshift-enterprise-cli-container-v4.20.0-202503281911.p0.g314ad39.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-tools
This PR has been included in build ose-tools-container-v4.20.0-202503281911.p0.g314ad39.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer
This PR has been included in build openshift-enterprise-deployer-container-v4.20.0-202503281911.p0.g314ad39.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts
This PR has been included in build ose-cli-artifacts-container-v4.20.0-202503281911.p0.g314ad39.assembly.stream.el9.
All builds following this will include this PR.

@petr-muller petr-muller deleted the revert-1997-ocpbugs-30080-cvo-placeholder-replacement branch April 15, 2025 15:23
petr-muller added a commit to petr-muller/oc that referenced this pull request Apr 15, 2025
@petr-muller
Revert "Revert "NO-JIRA: adm release new: simplify writePayload" (o…
af266e3 
…penshift#2000)"

This reverts commit 314ad39.
@petr-muller petr-muller mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@atiratree atiratree Awaiting requested review from atiratree

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petr-muller @openshift-ci-robot @jupierce @openshift-bot