Skip to content

NO-JIRA: claude: Change learn-* agents into skills#2257

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tchap:claude-learning-skills
Apr 20, 2026
Merged

NO-JIRA: claude: Change learn-* agents into skills#2257
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tchap:claude-learning-skills

Conversation

@tchap
Copy link
Copy Markdown
Contributor

@tchap tchap commented Apr 17, 2026

I was being retarded, learn-session needs to work with the current context, so it cannot really be an agent. Migrating learn-history for consistency also.

Summary by CodeRabbit

  • New Features

    • Skills now support persisting extracted knowledge to memory in addition to existing configuration destinations.
  • Improvements

    • Streamlined skill configuration by removing unused operational parameters for cleaner setup.
    • Updated documentation with dedicated section describing available skills and their purposes.
    • Refined skill instructions for improved clarity and user guidance.

learn-session needs to work with the current context, so it cannot
really be an agent. Migrating learn-history for consistency also.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@tchap: This pull request explicitly references no jira issue.

Details

In response to this:

I was being retarded, learn-session needs to work with the current context, so it cannot really be an agent. Migrating learn-history for consistency also.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e902715c-056e-41ad-a401-7920a628be59

📥 Commits

Reviewing files that changed from the base of the PR and between 8d2e625 and c2f7cc1.

📒 Files selected for processing (3)
  • .claude/skills/learn-history/SKILL.md
  • .claude/skills/learn-session/SKILL.md
  • README.md

Walkthrough

This pull request updates skill metadata and documentation across three files. Two skill configuration files are modified to broaden persistence targets to include "memory" and remove operational configuration fields, alongside instructional text refinements. The README is updated to document available skills with revised descriptions.

Changes

Cohort / File(s) Summary
Skill Configuration Updates
.claude/skills/learn-history/SKILL.md, .claude/skills/learn-session/SKILL.md
Updated skill metadata descriptions to include "memory" as a persistence target alongside existing targets. Removed tools, model, and maxTurns configuration fields. Revised instructional text with direct imperative phrasing and adjusted step descriptions.
Documentation
README.md
Added new section documenting available skills in .claude/skills/ directory with descriptions for learn-session and learn-history. Updated learn-history description from "One-shot analysis" to "Deep analysis".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting learn-* components from agents to skills, which is reflected in the file modifications across SKILL.md files and README updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies Claude configuration files in .claude/skills/ directory with no Ginkgo test files or test definitions present.
Test Structure And Quality ✅ Passed The custom check reviews Ginkgo test code quality, but this PR contains no Ginkgo test files, only configuration and documentation files.
Microshift Test Compatibility ✅ Passed PR modifies only configuration and documentation files, not Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only Claude AI skill definition files and README documentation. No new Ginkgo e2e tests or Go test files are being added, making this check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only Claude AI skill definitions in .claude/skills/ directory and README.md; does not contain deployment manifests, operator code, or controllers.
Ote Binary Stdout Contract ✅ Passed PR contains only markdown documentation changes with no Go code modifications, making the OTE Binary Stdout Contract check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only skill configuration and documentation files (markdown-based metadata), not Go test files with Ginkgo test blocks, so this check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tchap tchap marked this pull request as ready for review April 17, 2026 11:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2026
@openshift-ci openshift-ci bot requested review from atiratree and ingvagabund April 17, 2026 11:54
@ardaguclu
Copy link
Copy Markdown
Member

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@tchap
Copy link
Copy Markdown
Contributor Author

tchap commented Apr 20, 2026

/retest
/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@tchap: The verified label has been added.

Details

In response to this:

/retest
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2026

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 30bb6e5 into openshift:main Apr 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants