Skip to content

Update module github.com/fsnotify/fsnotify to v1.10.0#225

Open
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-fsnotify-fsnotify-1.x
Open

Update module github.com/fsnotify/fsnotify to v1.10.0#225
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-fsnotify-fsnotify-1.x

Conversation

@red-hat-konflux-kflux-prd-rh03
Copy link
Copy Markdown
Contributor

@red-hat-konflux-kflux-prd-rh03 red-hat-konflux-kflux-prd-rh03 Bot commented Apr 9, 2026

This PR contains the following updates:

Package Change Age Confidence
github.com/fsnotify/fsnotify v1.7.0v1.10.0 age confidence

Release Notes

fsnotify/fsnotify (github.com/fsnotify/fsnotify)

v1.10.0

Compare Source

This version of fsnotify needs Go 1.23.

Changes and fixes
  • inotify: improve initialization error message (#​731)

  • inotify: send Rename event if recursive watch is renamed (#​696)

  • inotify: avoid copying event buffers when reading names (#​741)

  • kqueue: skip dangling symlinks (ENOENT) in watchDirectoryFiles, so a bad entry no longer aborts Watcher.Add for the whole directory (#​748)

  • kqueue: drop watches directly in Close() to fix a file descriptor leak when recycling watchers (#​740)

  • windows: fix nil pointer dereference in remWatch (#​736)

  • windows: lock watch field updates against concurrent WatchList to fix a race introduced in v1.9.0 (#​709, #​749)

v1.9.0

Compare Source

Changes and fixes
  • all: make BufferedWatcher buffered again (#​657)

  • inotify: fix race when adding/removing watches while a watched path is being deleted (#​678, #​686)

  • inotify: don't send empty event if a watched path is unmounted (#​655)

  • inotify: don't register duplicate watches when watching both a symlink and its target; previously that would get "half-added" and removing the second would panic (#​679)

  • kqueue: fix watching relative symlinks (#​681)

  • kqueue: correctly mark pre-existing entries when watching a link to a dir on kqueue (#​682)

  • illumos: don't send error if changed file is deleted while processing the event (#​678)

v1.8.0

Compare Source

Additions

  • all: add FSNOTIFY_DEBUG to print debug logs to stderr (#​619)
Changes and fixes
  • windows: fix behaviour of WatchList() to be consistent with other platforms (#​610)

  • kqueue: ignore events with Ident=0 (#​590)

  • kqueue: set O_CLOEXEC to prevent passing file descriptors to children (#​617)

  • kqueue: emit events as "/path/dir/file" instead of "path/link/file" when watching a symlink (#​625)

  • inotify: don't send event for IN_DELETE_SELF when also watching the parent (#​620)

  • inotify: fix panic when calling Remove() in a goroutine (#​650)

  • fen: allow watching subdirectories of watched directories (#​621)


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci openshift-ci Bot requested review from bmeng and rbhilare April 9, 2026 12:04
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 9, 2026

Hi @red-hat-konflux-kflux-prd-rh03[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tkong-redhat
Copy link
Copy Markdown
Contributor

/ok-to-test

🤖 Claude claude@anthropic.com commenting on behalf of @tkong-redhat

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.67%. Comparing base (d7bd07a) to head (ea2707a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   55.67%   55.67%           
=======================================
  Files          23       23           
  Lines        1895     1895           
=======================================
  Hits         1055     1055           
  Misses        785      785           
  Partials       55       55           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh03 red-hat-konflux-kflux-prd-rh03 Bot force-pushed the konflux/mintmaker/master/github.com-fsnotify-fsnotify-1.x branch from 271197e to ea2707a Compare April 30, 2026 04:04
@red-hat-konflux-kflux-prd-rh03 red-hat-konflux-kflux-prd-rh03 Bot changed the title Update module github.com/fsnotify/fsnotify to v1.9.0 Update module github.com/fsnotify/fsnotify to v1.10.0 Apr 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux-kflux-prd-rh03[bot]
Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

@red-hat-konflux-kflux-prd-rh03[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants