Bug 1977329: [release-4.8] Allow DBStorageClass to be set from Storage Cluster CR for Noobaa by ezio-auditore · Pull Request #1264 · red-hat-storage/ocs-operator

ezio-auditore · 2021-07-07T08:19:31Z

Backport of #1298

Signed-off-by: Kaustav Majumder kmajumder@redhat.com

openshift-ci · 2021-07-07T08:19:36Z

@ezio-auditore: This pull request references Bugzilla bug 1977329, which is invalid:

expected the bug to target the "OCS 4.8.0" release, but it targets "OCS 4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1977329: [release-4.8] Allow DBStorageClass to be set from Storage Cluster CR for Noobaa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-07T08:19:46Z

Hi @ezio-auditore. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

umangachapagain

Changes needs to be done in master branch before we can backport it into 4.8.
This adds a new api spec, so I'm not sure if this can be taken directly into 4.8.

@agarwal-mudit @obnoxxx WDYT?

agarwal-mudit · 2021-07-09T07:29:07Z

/hold
Correct, release-4.8 is now frozen. Also, the BZ is not approved for 4.8 and we are already in RC

ezio-auditore · 2021-07-12T05:54:32Z

This has to be rebased until 4.8 is released and merged with 4.8.1. Also i think in 4.9 this spec will no more be required since MCG spec to be decoupled from storage cluster spec. This is something we require in Openshift Dedicated ODF addon to run MCG without consuming pv from ocs-ceph-rbd for nooba-db pod.

ezio-auditore · 2021-08-10T05:56:11Z

/bugzilla refresh

openshift-ci · 2021-08-10T05:56:14Z

@ezio-auditore: This pull request references Bugzilla bug 1977329, which is invalid:

expected the bug to target the "OCS 4.8.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agarwal-mudit · 2021-08-10T06:42:58Z

/ok-to-test
/cc @jarrpa

agarwal-mudit · 2021-08-10T06:44:17Z

/bugzilla refresh

openshift-ci · 2021-08-10T06:44:21Z

@agarwal-mudit: This pull request references Bugzilla bug 1977329, which is invalid:

expected the bug to target the "OCS 4.8.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

umangachapagain

Change looks good. But commit needs to be divided into 2.
We prefer Go changes in one commit and generated changes (CRD and CSV) in a separate commit.

ezio-auditore · 2021-08-10T13:41:52Z

@umangachapagain Moved generated changes in new commit.

agarwal-mudit · 2021-08-11T10:51:09Z

/bugzilla refresh

openshift-ci · 2021-08-11T10:51:15Z

@agarwal-mudit: This pull request references Bugzilla bug 1977329, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (OCS 4.8.1) matches configured target release for branch (OCS 4.8.1)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (sgatfane@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agarwal-mudit · 2021-08-11T10:51:20Z

/hold cancel

jarrpa · 2021-08-11T15:09:08Z

Closing in favor of #1302

openshift-ci · 2021-08-11T15:11:17Z

@ezio-auditore: This pull request references Bugzilla bug 1977329. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1977329: [release-4.8] Allow DBStorageClass to be set from Storage Cluster CR for Noobaa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jarrpa · 2021-08-11T20:39:09Z

...opening this up again because #1302 is invalid. 😂 This PR's branch should be (force) updated with the relevant fixes.

/hold

openshift-ci · 2021-08-11T20:42:22Z

@ezio-auditore: An error was encountered querying GitHub for users with public email (sgatfane@redhat.com) for bug 1977329 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1977329: [release-4.8] Allow DBStorageClass to be set from Storage Cluster CR for Noobaa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agarwal-mudit · 2021-08-12T00:38:52Z

/retest

openshift-ci · 2021-08-12T01:42:41Z

@ezio-auditore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws	`63d0be8`	link	`/test red-hat-storage-ocs-ci-e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

to specify the default storageclass to be used for noobaa-db pods Signed-off-by: Kaustav Majumder <kmajumder@redhat.com>

openshift-ci · 2021-08-12T03:49:39Z

@ezio-auditore: This pull request references Bugzilla bug 1977329, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (OCS 4.8.1) matches configured target release for branch (OCS 4.8.1)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (sgatfane@redhat.com), skipping review request.

Details

In response to this:

Bug 1977329: [release-4.8] Allow DBStorageClass to be set from Storage Cluster CR for Noobaa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jarrpa

/lgtm
/hold cancel

openshift-ci · 2021-08-12T03:51:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jarrpa,umangachapagain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-12T05:00:53Z

@ezio-auditore: All pull requests linked via external trackers have merged:

Bugzilla bug 1977329 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1977329: [release-4.8] Allow DBStorageClass to be set from Storage Cluster CR for Noobaa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jul 7, 2021

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 7, 2021

openshift-ci Bot requested review from davidvossel and umangachapagain July 7, 2021 08:19

openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2021

umangachapagain suggested changes Jul 9, 2021

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2021

openshift-ci Bot requested a review from jarrpa August 10, 2021 06:42

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021

openshift-ci Bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Aug 10, 2021

openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 10, 2021

umangachapagain suggested changes Aug 10, 2021

View reviewed changes

umangachapagain approved these changes Aug 10, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 11, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 11, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021

jarrpa closed this Aug 11, 2021

jarrpa reopened this Aug 11, 2021

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021

ezio-auditore added 2 commits August 12, 2021 09:19

Added DBStorageClassName to MultiCloudGatewaySpec

a65d34b

to specify the default storageclass to be used for noobaa-db pods Signed-off-by: Kaustav Majumder <kmajumder@redhat.com>

Generated changes

0de37d3

jarrpa approved these changes Aug 12, 2021

View reviewed changes

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021

openshift-ci Bot assigned jarrpa Aug 12, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021

openshift-ci Bot merged commit 6e47d5a into red-hat-storage:release-4.8 Aug 12, 2021

Conversation

ezio-auditore commented Jul 7, 2021 • edited by jarrpa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 7, 2021

Uh oh!

openshift-ci Bot commented Jul 7, 2021

Uh oh!

umangachapagain left a comment

Choose a reason for hiding this comment

Uh oh!

agarwal-mudit commented Jul 9, 2021

Uh oh!

ezio-auditore commented Jul 12, 2021

Uh oh!

ezio-auditore commented Aug 10, 2021

Uh oh!

openshift-ci Bot commented Aug 10, 2021

Uh oh!

agarwal-mudit commented Aug 10, 2021

Uh oh!

agarwal-mudit commented Aug 10, 2021

Uh oh!

openshift-ci Bot commented Aug 10, 2021

Uh oh!

umangachapagain left a comment

Choose a reason for hiding this comment

Uh oh!

ezio-auditore commented Aug 10, 2021

Uh oh!

agarwal-mudit commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

agarwal-mudit commented Aug 11, 2021

Uh oh!

jarrpa commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

jarrpa commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

agarwal-mudit commented Aug 12, 2021

Uh oh!

openshift-ci Bot commented Aug 12, 2021

Uh oh!

openshift-ci Bot commented Aug 12, 2021

Uh oh!

jarrpa left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 12, 2021

Uh oh!

openshift-ci Bot commented Aug 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ezio-auditore commented Jul 7, 2021 •

edited by jarrpa

Loading