Skip to content

Comments

bug 1878153: [release-4.6] Add commands to gather_clusterscoped_resources.#825

Merged
openshift-merge-robot merged 2 commits intored-hat-storage:release-4.6from
openshift-cherrypick-robot:cherry-pick-812-to-release-4.6
Oct 14, 2020
Merged

bug 1878153: [release-4.6] Add commands to gather_clusterscoped_resources.#825
openshift-merge-robot merged 2 commits intored-hat-storage:release-4.6from
openshift-cherrypick-robot:cherry-pick-812-to-release-4.6

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 13, 2020

This is an automated cherry-pick of #812

/assign crombus

@crombus
must-gather: move oc get/describe node command
5776eff 
move the oc get/describe node command from
gather_namespaced_resources to
gather_clusterscoped_resources

Signed-off-by: crombus <pkundra@redhat.com>
@crombus
must-gather: add and modify gather_clusterscoped_resources
4831e96 
add describe list for commands and modify their filenames

Signed-off-by: crombus <pkundra@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2020
Merged
@crombus crombus changed the title [release-4.6] Add commands to gather_clusterscoped_resources. bug 1878153: [release-4.6] Add commands to gather_clusterscoped_resources. Oct 13, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1878153, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "OCS 4.6.0" instead
  • expected Bugzilla bug 1878153 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

bug 1878153: [release-4.6] Add commands to gather_clusterscoped_resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 13, 2020
@crombus crombus added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 13, 2020
agarwal-mudit
agarwal-mudit approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@agarwal-mudit
Copy link
Member

agarwal-mudit commented Oct 14, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2020
@agarwal-mudit
Copy link
Member

agarwal-mudit commented Oct 14, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2020

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 4831e96 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Oct 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 410c026 into red-hat-storage:release-4.6 Oct 14, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1878153 has been moved to the MODIFIED state.

Details

In response to this:

bug 1878153: [release-4.6] Add commands to gather_clusterscoped_resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agarwal-mudit agarwal-mudit agarwal-mudit approved these changes

@crombus crombus Awaiting requested review from crombus

@egafford egafford Awaiting requested review from egafford

Assignees

@crombus crombus

@agarwal-mudit agarwal-mudit

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @agarwal-mudit @openshift-bot @crombus @openshift-merge-robot